refact(system-update): remove redundant DNF instructions #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
changed the title
|
I always get confused between refactor and bugfix |
adamperkowski
changed the title
bugfix fixes an issue that breaks functionality |
|
Duplicate of #843 |
adamperkowski
added
duplicate
|
@Angxddeep This does seem like a duplicate. I'll close this PR and commit your additional changes to #843 |
adamperkowski
pushed a commit
to jeevithakannan2/linutil
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Dnf upgrade is more than enough, dnf update is just a subset of upgrade, so there is really no need for it.
Testing
Works
Checklist