Skip to content

Conversation

Jaredy899
Copy link
Contributor

@Jaredy899 Jaredy899 commented Feb 15, 2025

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Fixes Build Prerequistes for Fedora and RHEL. Uses powertools for older rhel or rocky and crb for new builds. Also development tools work with dnf 4 or 5.

Testing

Tested on Fedora 39, 41 and Rocky 9.

Issues / other PRs related

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review February 15, 2025 02:03
@Jaredy899 Jaredy899 closed this Feb 15, 2025
@Jaredy899 Jaredy899 reopened this Feb 15, 2025
@adamperkowski
Copy link
Collaborator

adamperkowski commented Feb 15, 2025

hey. a little hint: if for some reason you can't apply shellcheck's suggestion, use shellcheck disable comments before the line.

@adamperkowski adamperkowski added bug Something isn't working script Pull requests that update scripts labels Feb 15, 2025
@Jaredy899
Copy link
Contributor Author

I believe this passes the shellcheck.

Jaredy899 and others added 2 commits February 15, 2025 10:32
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisTitusTech ChrisTitusTech merged commit 0fc8f07 into ChrisTitusTech:main Feb 28, 2025
4 checks passed
@Jaredy899 Jaredy899 deleted the dnf-compile branch February 28, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working script Pull requests that update scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnf build prereqs fails
3 participants