fix(dwm-titus): Multiple fixes #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
approved these changes
Feb 15, 2025
adamperkowski
added
bug
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
|
Made some adjustments to take advantage of the common-service-script for consistency. (I'm testing this script with void whenever that gets added) |
|
@adamperkowski Can you check everything again? I changed a few things and added alpine. |
adamperkowski
requested changes
Feb 22, 2025
|
@adamperkowski I corrected my error and addressed the other problems that shellcheck was catching. Did a quick test on all the distros and it works |
4 tasks
4 tasks
adamperkowski
approved these changes
Feb 22, 2025
ChrisTitusTech
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added picom depends for apt, dnf, and zypper. Added Zypper, and Alpine for install. Slight change in dm check.
Testing
Tested in Arch, Fedora 41, Debian, Opensuse Tumbleweed, Alpine
Impact
Issues / other PRs related
Additional Information
I know Chris may be picky about touching dwmtitus...
Checklist