Skip to content

fix(github-desktop): openSUSE #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix(github-desktop): openSUSE #1043

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4365e9
fix github desktop install
Jaredy899 Mar 4, 2025
d0f2219
Update githubdesktop.sh
Jaredy899 Mar 4, 2025
12616fc
pass shellcheck
Jaredy899 Mar 4, 2025
13d07fb
Update githubdesktop.sh
Jaredy899 Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/tabs/applications-setup/developer-tools/githubdesktop.sh
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not saying that this is outright malicious, but I just want to make reviewers aware of the package source domain change, which should be scrutinized by someone with adequate knowledge

Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ installGithubDesktop() {
"$ESCALATION_TOOL" "$PACKAGER" install -y github-desktop
;;
zypper)
"$ESCALATION_TOOL" rpm --import https://rpm.packages.shiftkey.dev/gpg.key
printf "%b\n" '[shiftkey-packages]\nname=GitHub Desktop\nbaseurl=https://rpm.packages.shiftkey.dev/rpm/\nenabled=1\ngpgcheck=1\nrepo_gpgcheck=1\ngpgkey=https://rpm.packages.shiftkey.dev/gpg.key\n' | "$ESCALATION_TOOL" tee /etc/zypp/repos.d/shiftkey-packages.repo > /dev/null
"$ESCALATION_TOOL" rpm --import https://packagecloud.io/shiftkey/desktop/gpgkey
"$ESCALATION_TOOL" sh -c 'echo -e "[shiftkey]\nname=GitHub Desktop\nbaseurl=https://packagecloud.io/shiftkey/desktop/el/7/\$basearch\nenabled=1\ngpgcheck=0\nrepo_gpgcheck=1\ngpgkey=https://packagecloud.io/shiftkey/desktop/gpgkey" > /etc/zypp/repos.d/github-desktop.repo'
"$ESCALATION_TOOL" "$PACKAGER" refresh
"$ESCALATION_TOOL" "$PACKAGER" --non-interactive install github-desktop
;;
Expand Down