Skip to content

fix builds essentials for debian based systems #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2025
Merged

fix builds essentials for debian based systems #1075

merged 5 commits into from
Jun 26, 2025

Conversation

Jaredy899
Copy link
Contributor

@Jaredy899 Jaredy899 commented Jun 22, 2025 •
edited
Loading

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Fixes build essentials install for debian based system. Shellcheck (quotes) was causing errors.

Testing

Debian, Ubuntu

Impact

Double quotes were messing up most of the builds on the script. I disabled shellcheck

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

jeevithakannan2
jeevithakannan2 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was fixed in 89bbc52 but reintroduced again in 5f7de33

Thank you

@alexanderbrown21
Copy link
Contributor

Thanks, much appreciated @Jaredy899

@Jaredy899
fix
bda47bf 
be nice if i could write code correctly the first time
@ChrisTitusTech ChrisTitusTech merged commit 97be530 into ChrisTitusTech:main Jun 26, 2025
4 checks passed
@Jaredy899 Jaredy899 deleted the compile branch June 26, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

+1 more reviewer

@jeevithakannan2 jeevithakannan2 jeevithakannan2 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build prerequisites error
4 participants
@Jaredy899 @alexanderbrown21 @ChrisTitusTech @jeevithakannan2