-
Notifications
You must be signed in to change notification settings - Fork 333
Feat: Add support for installation of Chaotic-AUR in Linutil #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Githubguy132010 i haven't read the description that this is ai generated code and you don't know it will work either or not. Please do not contribute to any project without knowing what the tf you are doing. this is not your place to be work around if you don't understand a code by yourself. also what the aim you are making that "code looks good to me" can you measure the code that will work by reading the code wtf. also this is against the contribution guidelines "for you info". Even knowing that why you feel a necessary point to contribute. you can just open an feature issue and anyone who know they will do that. you don't have to make your hand dirty with a fuc*ing ai slop code. if you don't know anything about coding stay far from this environment also don't paste the ai slop to any project calling that "a contribution". i request to maintainers and @ChrisTitusTech to close this pr and take some action against this type of contribution. thank you |
The code is correct. But, you don't know if the code really works until you test it. That is what I meant with 'I don't know if the code will work or not" The code is correct, but I can't test it myself. PS: Thanks for the hilarious roasting 😂 I almost died of laughing while I read your review. |
how tf you can contribute to any project without even testing. and please this is not your standup comedy show here so no need create a drama here. "code is correct i haven't tested it and i don't know it will work or not" what is this fucking point lmao |
how the tf you are contributing to any project going against the contribution guidelines. |
If you are not supposed to use AI in this project, then why tf is there an opencode config? |
I'm asking for someone else to test ot. That's the point. I am limited by not having an Arch system. |
Good point, but it's not explicitly stated that you can't use LLM's. It's recommending against using LLM's if you don't understand the code it's writing. You CAN use it, but only if you understand the code. I do. |
i don't know wtf is opencode or whatever. but even if you write code with ai you have to understand what the code is and what it will do. btw did you understand bash script or any coding? i am asking also the point is without testing don't submit a pr. you are telling that " this is a ai slop i don't know wtf is this i haven't tested it i don't know this shit will work or not " what is this fucking point btw? can you explain |
Opencode is a fucking tool to let AI write code for you. And yes, I understand the code. I can read if the bash code is correct. I do know wtf this is. |
If you are not allowed to write code with AI, then don't merge a config dir with an instructions file for Opencode to tell it how to handle the project. |
we or i just mean you need to understand and mainly test the code. if it work as you expect then you can submit the pr with proper description of what you have actually done. didn't you read your description yourself? also that opencode config is push by chris ( creator of linutil ). btw he doesn't push any fucking ai slop to the repo he know how to code bash and understand well. But i can clearly see you have just pushed the fucking ai slop without even testing. |
That's because I can't test it myself because I'm on Ubuntu ARM. And I tried to use a ARM64 Arch container, but that refused to work. So, I want to ask you or anyone else to test it for me. And, to you question if I did read the description: Yes, I did. I made myself. I spent 15 minutes typing it out. |
Why did Chris push the config himself if you are not allowed to use AI? Then, the config would be useless. |
i can appreciate for your willingness to contribute. but if you are lacking your resource's you can't do anything i can understand. idk they should update contribution guidelines in terms of ai thing's. but also my concern is that the code you have done is calling yet another shell script from another person. first improve that if you want to contribute. we can mention maintainer's to review and test if needed. ai code is accepted until and unless "it is not a trash code". also you need to understand first. i don't wanna make you bad. Just if you can improve the code as much as you can yourself rather then ai. Understand it and Be able to explain us the code you have written. |
I don't think this is correct. Right? It prints the lines that need to be added to pacman.conf, then tee captures it and stores it in pacman.conf |
\n[chaotic-aur]\ add a line break before chaotic aur. it's correct but at first look how they are doing in other script's like print from common script. Edit: also see the code style they perfer |
So, use print instead of echo or tee? |
yes linutil use POSIX script's so use printf no don't replace tee that is fine see any script for reference https://github.com/ChrisTitusTech/linutil/blob/main/core/tabs/applications-setup/android-debloat.sh |
Ah, now I see! I changed it. |
Everything is correct, but I'm skeptical about the |
don't use $packager here use direct pacman-key here |
mostly it is fine now. but testing is needed to ensure it work correctly. i don't have my machine here & i am out of my town. so i request @ChrisTitusTech to test and review this. also @Githubguy132010 make sure this is formatted by shfmt. thanks for your contribution:) edit: you can open this pr for review |
I did that. But how do I use shfmt? |
have a look at official repo of shfmt install it and use default value for formatting for now. edit: i guess this is default |
I applied the formatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This will merge after being test and approved by @ChrisTitusTech.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thank you.
The primary Chaotic AUR keyring mirror appears to be down. As a temporary workaround, please refer to the following Telegram post for an alternative source: https://t.me/chaotic_aur_sac/298266 |
Everybody please ignore @thepinak503 comment and prefer offical site. |
Type of Change
Description
I added support for the installation of the Chaotic-AUR repo for Arch systems. I added a new script that installs and configures the Chaotic-AUR repo. I also updated the corresponding tab data. This aims to solve #1115
Testing
I was not able to test the change in linutil due to me not having an Arch system and running on a ARM64 machine, but linutil compiled withouy any errors and ran like it should. If anyone can test my changes, that would be great.
Impact
The change impacts the user experience by making the install of the Chaotic-AUR quick and easy. No performace hit measured. No new dependencies were added.
Issues / other PRs related
Additional Information
This is AI-generated code! I know it's against the contributors guidelines, but the code looks correct to me. To be sure that the code works, please review this PR very carefully. I don't know if the code itself works, so I will be opening this PR as a draft.
NOTE: If you see unrelated docs changes, that's because of running docgen.
Checklist