Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

Pull Request

Title

Fix floating window color and text rendering

Type of Change

  • Bug fix
  • UI/UX improvement

Description

  • Fixed the issue where background text and colors are displayed in the floating window
  • This is fixed by rendering spaces if there is an empty line and resetting the foreground color

Before

color

After

no-color

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this & it works like a charm; even in scripts that include color. Thanks!

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Sep 18, 2024

#387 Has a better implementation of than this PR so closing this PR

@jeevithakannan2 jeevithakannan2 deleted the floating-render-fix branch September 18, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant