NerdFonts installer script added and consequential change to tab_data TOML file. by fam007e · Pull Request #446 · ChrisTitusTech/linutil

fam007e · 2024-09-17T14:00:26Z

Type of Change

Description

The NerdFonts installer script has been added, allowing users to select and install a variety of NerdFonts through a command-line interface. This feature ensures that the required fonts are downloaded and installed in the user’s ~/.local/share/fonts directory. Additionally, the font cache is updated to reflect the changes.

A consequential change has been made to the tab_data TOML file to integrate the new functionality and ensure smooth operation across the platform.

Key Features:

Users can select multiple fonts from a displayed list with scroll functionailty via less.
Fonts are downloaded from the latest NerdFonts GitHub release.
The font cache is automatically updated after installation.

Testing

Ran the script to verify correct downloading and installation of multiple fonts.
Verified that the font cache updates properly and fonts are available for use.
Tested the TOML changes for integration with the current configuration.

Impact

This feature will allow users to easily install and manage NerdFonts, reducing manual download and installation time. There are no new dependencies outside the standard utilities (curl, tar,less) except that of fc-cache from fontconfig.

Issue related to PR

Additional Information

No additional information at this time.

Checklist

My code adheres to the coding and style guidelines of the project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have made corresponding changes to the documentation.
My changes generate no errors/warnings/merge conflicts.

…tab_data toml file.

koibtw · 2024-09-17T14:20:15Z

No way to scroll here when the terminal with linutil is smaller

koibtw · 2024-09-17T14:22:24Z

tabs/system-setup/nerdfonts-installer.sh

+                curl -sSLo "$HOME/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz"
+
+                # Extract and install the font
+                mkdir -p ~/.local/share/fonts
+                tar -xf "$HOME/tmp/$font_name.tar.xz" -C "$HOME/.local/share/fonts"
+                rm "$HOME/tmp/$font_name.tar.xz"


Suggested change

curl -sSLo "$HOME/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz"

# Extract and install the font

mkdir -p ~/.local/share/fonts

tar -xf "$HOME/tmp/$font_name.tar.xz" -C "$HOME/.local/share/fonts"

rm "$HOME/tmp/$font_name.tar.xz"

curl -sSLo "/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz"

# Extract and install the font

mkdir -p ~/.local/share/fonts

tar -xf "/tmp/$font_name.tar.xz" -C "$HOME/.local/share/fonts"

rm "/tmp/$font_name.tar.xz"

@adamperkowski ~~this needs escalation_tool you cannot curl a file inside of the root file system without root permissions~~ nvm tested it and it works, learn something new everyday

@nnyyxxxx I'm pretty sure you're wrong this time. The default /tmp permissions are drwxrwxrwt. The t at the end means that only the owner of a file or the root user can modify.

koibtw · 2024-09-17T14:24:25Z

tabs/system-setup/nerdfonts-installer.sh

+                checkCommandRequirements "tar"
+
+                # Download the font
+                curl -sSLo "$HOME/tmp/$font_name.tar.xz" "https://github.com/ryanoasis/nerd-fonts/releases/latest/download/$font_name.tar.xz"


curl: (3) URL rejected: Malformed input to a URL function

tar and curl are preloaded so what's the issue here.
I could not reproduce your error: curl: (3) URL rejected: Malformed input to a URL function

tar and curl are preloaded so what's the issue here. I could not reproduce your error: curl: (3) URL rejected: Malformed input to a URL function

Then you did not test it, "TMP" a folder inside of the root file system does not exist inside of the users home directory

koibtw

Rename nerdfonts-installer.sh to nerdfonts.sh

tabs/system-setup/tab_data.toml

koibtw · 2024-09-17T14:30:11Z

The script should also check if fontconfig is installed.

koibtw · 2024-09-17T14:39:13Z

I'm sorry but I cannot approve 100% LLM generated PRs. You need to rewrite the code yourself.

Co-authored-by: Adam Perkowski <adas1per@protonmail.com>

fam007e · 2024-09-17T14:51:58Z

No way to scroll here when the terminal with linutil is smaller

I used my 15" laptop and I also think even if it's 14" or 13" its okay so how can you make it posix compliant and fit it in within the scope i.e. having to add scroll functionality is beyond my level of understanding... So forgive me I can NOT accomplish that task.

koibtw · 2024-09-17T14:58:11Z

how can you make it posix compliant and fit it in within the scope i.e. having to add scroll functionality is beyond my level of understanding...

You can use printf with read (#282) or just craft a string and more it.

fam007e · 2024-09-17T15:02:46Z

The script should also check if fontconfig is installed.

Shouldn't I add check for fc-cache command instead.

koibtw · 2024-09-17T15:13:36Z

Shouldn't I add check for fc-cache command instead.

You should check if fontconfig exists in the system. If not, install it.

You can do command_exists fc-cache and if not, install fontconfig.

fam007e · 2024-09-17T15:28:59Z

Shouldn't I add check for fc-cache command instead.

You should check if fontconfig exists in the system. If not, install it.

You can do command_exists fc-cache and if not, install fontconfig.

I think the issue with that is if debian has other utility which installs fontconfig.

…oviding the ability to scroll both forwards and backwards through the list of fonts

fam007e · 2024-09-17T15:33:22Z

Shouldn't I add check for fc-cache command instead.

You should check if fontconfig exists in the system. If not, install it.

You can do command_exists fc-cache and if not, install fontconfig.

May be the "and if not" part be actually implemented in common-script rather than in individual cases like this... 🤔

koibtw · 2024-09-17T15:34:26Z

I think the issue with that is if debian has other utility which installs fontconfig.

You can use

case $PACKAGER in
apt|nala)
    # debian stuff
    ;;
...

koibtw · 2024-09-17T15:38:57Z

@fam007e Draft this with #447 & #448 for now. Chris is supposed to be streaming soon.

fam007e · 2024-09-17T15:48:34Z

@fam007e Draft this and #447 for now. Chris is supposed to be streaming soon.

I had another one of using cli to setup ssh to github along with nerdfonts and bootloader-switcher. These three were made into 1 PR. However, one maintainer suggested to do three separate so I had to use Claude LLM to write the PRs' text as I am quite busy this week. Sorry about all that. 🙏

nerdfonts installer script added and consequential change is made to …

022cb04

…tab_data toml file.

koibtw requested changes Sep 17, 2024

View reviewed changes

tabs/system-setup/tab_data.toml Outdated Show resolved Hide resolved

Update tabs/system-setup/tab_data.toml

1bcdb20

Co-authored-by: Adam Perkowski <adas1per@protonmail.com>

check cmd req for fc-cache added and less is used instead of more, pr…

87ef718

…oviding the ability to scroll both forwards and backwards through the list of fonts

ok if this is not to your liking close and trash the PR, I am done

e1a52d0

ghost mentioned this pull request Sep 17, 2024

Add code understanding & testing point to Contributing Guidelines #451

Merged

2 tasks

fam007e closed this Sep 18, 2024

Conversation

fam007e commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Description

Key Features:

Testing

Impact

Issue related to PR

Additional Information

Checklist

Uh oh!

koibtw commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koibtw Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Sep 17, 2024 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

koibtw Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

koibtw Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

fam007e Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

ghost Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

koibtw left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

koibtw commented Sep 17, 2024

Uh oh!

koibtw commented Sep 17, 2024

Uh oh!

fam007e commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

koibtw commented Sep 17, 2024

Uh oh!

fam007e commented Sep 17, 2024

Uh oh!

koibtw commented Sep 17, 2024

Uh oh!

fam007e commented Sep 17, 2024

Uh oh!

fam007e commented Sep 17, 2024

Uh oh!

koibtw commented Sep 17, 2024

Uh oh!

koibtw commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fam007e commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fam007e commented Sep 17, 2024 •

edited

Loading

koibtw commented Sep 17, 2024 •

edited

Loading

ghost Sep 17, 2024 •

edited by ghost

Loading

koibtw left a comment •

edited

Loading

fam007e commented Sep 17, 2024 •

edited

Loading

koibtw commented Sep 17, 2024 •

edited

Loading

fam007e commented Sep 17, 2024 •

edited

Loading