Skip to content

added browser setup script #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2024
Merged

added browser setup script #498

merged 3 commits into from
Sep 19, 2024

Conversation

guruswarupa
Copy link
Contributor

@guruswarupa guruswarupa commented Sep 19, 2024 •
edited
Loading

Pull Request

added browser setup script

  • a script to install popular browsers(brave , chrome, chromium,firefox, vivaldi, lynx) for arch, debian, opensuse and fedora based distros

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

ghost
ghost suggested changes Sep 19, 2024
View reviewed changes
ghost
ghost suggested changes Sep 19, 2024
View reviewed changes
ghost
ghost suggested changes Sep 19, 2024
View reviewed changes
ghost
ghost suggested changes Sep 19, 2024
View reviewed changes
adamperkowski
adamperkowski requested changes Sep 19, 2024
View reviewed changes
ghost
ghost suggested changes Sep 19, 2024
View reviewed changes
adamperkowski
adamperkowski requested changes Sep 19, 2024
View reviewed changes
adamperkowski
adamperkowski requested changes Sep 19, 2024
View reviewed changes
@ghost ghost mentioned this pull request Sep 19, 2024
Closed
adamperkowski
adamperkowski requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u forgot about --noconfirm :))

ChrisTitusTech and others added 2 commits September 19, 2024 11:53
@ChrisTitusTech @adamperkowski
Update tabs/applications-setup/browser-setup.sh
56ddc8c 
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
@ChrisTitusTech @adamperkowski
Update tabs/applications-setup/browser-setup.sh
fe3a1fa 
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
@ChrisTitusTech ChrisTitusTech merged commit a78145f into ChrisTitusTech:main Sep 19, 2024
1 check passed
@guruswarupa
Copy link
Contributor Author

Now after seeing my PR you're making changes? Funny

maintainers know who made the actual script. just work on yours. adam asked me to add lynx and i did and then squashed.

@Angxddeep
Copy link
Contributor

image
Well didn't work on fedora

@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
@guruswarupa
Copy link
Contributor Author

It's all good. Now that my PR got closed I'll add those additions to the script

Yes that's what I wanted you to do thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamperkowski adamperkowski adamperkowski requested changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guruswarupa @Angxddeep @ChrisTitusTech @adamperkowski