Made popup title customizable. The Script's preview title is now its command name #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsofrancof
changed the title
adamperkowski
approved these changes
Sep 23, 2024
afonsofrancof
force-pushed
the
generic-popup-title
branch
from
710f9bd to
77962e2
Compare
afonsofrancof
changed the title
…eneric-popup-title
afonsofrancof
force-pushed
the
generic-popup-title
branch
from
fd66661 to
34ffbc5
Compare
|
Pls see #724 |
7 tasks
ghost
mentioned this pull request
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The popup window now takes a title when being created.
This allows us to select any title we want instead of having predefined titles.
This made it possible for the script previews to now have a custom title each (It just uses the command name from the list)
Future
I also want to add word wrapping to the command descriptions because as of right now they go out of the screen and we need to scroll to see them, which is weird for a description.