Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 24, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Fix cloning issues.
  • Curl errors sometime happens when already existing file with the same name is found.

Testing

  • No errors

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if removing the backup is a good idea. We might want to prompt user which one to overwrite.

@jeevithakannan2
Copy link
Contributor Author

It's removing already existing linutilbackup. User wouldn't have a linutilbackup. Most of users rename to bak or backup and not linutilbak. So I think it won't be a problem

@cartercanedy
Copy link
Contributor

It's removing already existing linutilbackup. User wouldn't have a linutilbackup. Most of users rename to bak or backup and not linutilbak. So I think it won't be a problem

That check was there to prevent overwriting the users original config in the event that they run the command multiple times. I'd revert that change asap

@adamperkowski
Copy link
Collaborator

So I think it won't be a problem

It most certainly would

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont approve of this at all, too many issues here

@ghost
Copy link

ghost commented Sep 24, 2024

image
i cant reproduce the issue you're having either.

@jeevithakannan2 jeevithakannan2 marked this pull request as draft September 24, 2024 17:06
@jeevithakannan2 jeevithakannan2 deleted the config-fix branch September 24, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Curl errors when installing applications

3 participants