Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 29, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Remove unnecessary quotes around packages variable in compile-setup and gaming-setup.

Testing

  • Tested on arch linux works, no issues.

Issues / other PRs related

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@JirakLu
Copy link
Contributor

JirakLu commented Sep 29, 2024

Same issue happens for gaming-setup.sh:26

@jeevithakannan2
Copy link
Contributor Author

@JirakLu Ok will look into it

@cartercanedy
Copy link
Contributor

@jeevithakannan2 please take a look at the files changed in #454, it looks like some arrays got quoted erroneously by @nnyyxxxx

@cartercanedy
Copy link
Contributor

Might be worth running a grep over the repo to find other any other quoted arrays, as well

@ghost
Copy link

ghost commented Sep 30, 2024

it looks like some arrays got quoted erroneously by @nnyyxxxx

wrong

@ghost
Copy link

ghost commented Sep 30, 2024

there are no instances of arrays getting erroneously quoted in my PR

@ghost
Copy link

ghost commented Sep 30, 2024

the only vars that got quoted in my PR were packager and escalation tool, and it was suggested by Chris that i do that

@ghost
Copy link

ghost commented Sep 30, 2024

it's also good practice to quote vars anyways, but it depends on the context behind those vars

@cartercanedy
Copy link
Contributor

My bad, you're the first person that comes up in the git blame, so I must've misinterpreted the diffs. Either way, might be good to have your eyes on this.

@jeevithakannan2
Copy link
Contributor Author

@jeevithakannan2 please take a look at the files changed in #454, it looks like some arrays got quoted erroneously by @nnyyxxxx

Yeah I will take a look at it later. I have exams this week. Will do it during my leisure time

@cartercanedy
Copy link
Contributor

cartercanedy commented Sep 30, 2024

it's also good practice to quote vars anyways, but it depends on the context behind those vars

Agreed, but arrays are one of those exceptions* unless being used in an eval

@jeevithakannan2
Copy link
Contributor Author

If it is an array it will consider it as a string with space not as arrays, that's the problem here.

@cartercanedy
Copy link
Contributor

Correct, unless you're doing a string expansion inside the argument to eval or exec

@ChrisTitusTech ChrisTitusTech merged commit 75f066f into ChrisTitusTech:main Oct 8, 2024
2 checks passed
@jeevithakannan2 jeevithakannan2 deleted the compile-setup-fix branch October 9, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arch multiple package installation using pacman/yay/paru openSUSE Tumbleweed missing packages under Build Prerequisites

5 participants