-
Notifications
You must be signed in to change notification settings - Fork 346
fix: Remove quotes for packages #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove quotes for packages #695
Conversation
Same issue happens for |
@JirakLu Ok will look into it |
@jeevithakannan2 please take a look at the files changed in #454, it looks like some arrays got quoted erroneously by @nnyyxxxx |
Might be worth running a grep over the repo to find other any other quoted arrays, as well |
wrong |
there are no instances of arrays getting erroneously quoted in my PR |
the only vars that got quoted in my PR were packager and escalation tool, and it was suggested by Chris that i do that |
it's also good practice to quote vars anyways, but it depends on the context behind those vars |
My bad, you're the first person that comes up in the git blame, so I must've misinterpreted the diffs. Either way, might be good to have your eyes on this. |
Yeah I will take a look at it later. I have exams this week. Will do it during my leisure time |
Agreed, but arrays are one of those exceptions* unless being used in an |
If it is an array it will consider it as a string with space not as arrays, that's the problem here. |
Correct, unless you're doing a string expansion inside the argument to |
Type of Change
Description
Testing
Issues / other PRs related
Checklist