Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Oct 1, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Multi selection is now implemented at the command level instead of at the tab level.
  • Selected commands are retained even when switching between tabs.
  • To disable multi selection for a specific command, specify it under [[data]] or [[data.entry]] in toml
  • To disable multi selection for a list of sub entries, define it at the [[data]] level.
  • By default multi selection is enabled unless explicitly disabled in the toml file
  • Non multi select commands will be dimmed to let the users know they cannot be selected

image

Testing

  • Works as expected.

Issues / other PRs related

Additional Information

  • Multi select is disabled for certain utilities and critical commands
  • Not all the critical commands has been disabled; this can be disabled in the future.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Contributor

@cartercanedy cartercanedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@ChrisTitusTech ChrisTitusTech merged commit 67b7499 into ChrisTitusTech:main Nov 5, 2024
3 checks passed
@jeevithakannan2 jeevithakannan2 deleted the multi-select-refact branch November 8, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🦀 bug(?): Multi-select breaking in System Setup & Utilities tabs

4 participants