return user to their previous position if they exit a subdir

[ghost]

watch the video

Type of Change

• New feature

Description

takes the user back to their previous position when they exit a subdir

tested with a subdir inside of a subdir works as expected

tested with a regular subdir works as expected as well

example:

2024-10-02-00-19-31.mp4

before, it would just take u back to the first entry in the list

[cartercanedy]

Put visit_stack and position_stack together:

// ...
    visit_stack: Vec<(Rc<ListNode>, usize)>
// ...

Correction:

// ...
    visit_stack: Vec<(NodeId, usize)>,
// ...

[ghost]

Put visit_stack and position_stack together:

// ...
    visit_stack: Vec<(Rc<ListNode>, usize)>
// ...

its best we keep them separated

[cartercanedy]

its best we keep them separated

Besides unnecessarily making a heap allocation, they're both participating in the same functionality; they're best together

[ghost]

its best we keep them separated

Besides unnecessarily making a heap allocation, they're both participating in the same functionality; they're best together

sorry but i see no performance impact with this current implementation, if we want to combine them then we can refactor it in the future. For now this implementation is just a stepping stone.

[cartercanedy]

sorry but i see no performance impact with this current implementation, if we want to combine them then we can refactor it in the future. For now this implementation is just a stepping stone.

My point is less about immediate performance issues and more about not accumulating code that should get refactored down the road...

I figure that there's no better time than now
Just opened a PR for your fork, you're free to merge the changes if you want

[cartercanedy]

I also realize that my initial suggestion was actually incorrect, so that might've been confusing the situation. My 3y/o was a little cranky last night, so that made me a little cranky as well :))

[cartercanedy]

Awesome, thanks for merging that commit