Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Refactored to use the crossterm bundled with ratatui. This ensures version compatibility and reduces the risk of future breakage due to mismatched versions.

Testing

  • Works without error

Impact

  • There is no longer a need to manually maintain a separate version of crossterm in the project. This eliminates potential compatibility issues with ratatui that may occur in the future.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2 jeevithakannan2 changed the title chore: Use ratatui bundled crossterm chore: Use crossterm bundled with ratatui Oct 12, 2024
@adamperkowski
Copy link
Collaborator

You've got conflicts in filter.rs

@adamperkowski adamperkowski added rust Pull requests that update Rust code refactor labels Oct 25, 2024
@ChrisTitusTech ChrisTitusTech merged commit 176b19d into ChrisTitusTech:main Nov 6, 2024
3 checks passed
@jeevithakannan2 jeevithakannan2 deleted the crossterm branch November 7, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants