Skip to content

feat: Add Arch virtualization setup script #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2024
Merged

feat: Add Arch virtualization setup script #813

merged 7 commits into from
Nov 7, 2024

Conversation

jeevithakannan2
Copy link
Contributor

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Add basic virtualization setup script in ARCH.

Testing

  • Works as expected

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

adamperkowski
adamperkowski requested changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a quick note about CPU / BIOS virtualization settings

@jeevithakannan2 @adamperkowski
Update core/tabs/system-setup/arch/virtualization.sh
1ee60ff 
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
@jeevithakannan2
Copy link
Contributor Author

Might be worth adding a quick note about CPU / BIOS virtualization settings

That's why I added arch wiki link when kvm is not enabled. Arch Wiki has the details about CPU / BIOS virtualization.

@adamperkowski
Copy link
Collaborator

Might be worth adding a quick note about CPU / BIOS virtualization settings

That's why I added arch wiki link when kvm is not enabled. Arch Wiki has the details about CPU / BIOS virtualization.

Yea i know but I'm thinking maybe sometjing more direct like "make sure you have CPU virtualization support enabled in your BIOS/UEFI settings"

@jeevithakannan2 @adamperkowski
Update virtualization.sh
8e400f7 
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
lj3954
lj3954 suggested changes Oct 14, 2024
View reviewed changes
@jeevithakannan2 @lj3954
Update core/tabs/system-setup/arch/virtualization.sh
41ff081 
Co-authored-by: Liam <33645555+lj3954@users.noreply.github.com>
@ChrisTitusTech ChrisTitusTech merged commit e316224 into ChrisTitusTech:main Nov 7, 2024
4 checks passed
@jeevithakannan2 jeevithakannan2 deleted the virtual-manager branch November 7, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamperkowski adamperkowski adamperkowski requested changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

+1 more reviewer

@lj3954 lj3954 lj3954 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeevithakannan2 @adamperkowski @ChrisTitusTech @lj3954