Skip to content

Conversation

pxhale
Copy link
Contributor

@pxhale pxhale commented Oct 16, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

  • Added Tor Browser as an option in the Web Browsers tab.

Testing

  • Tested on Arch Linux and Debian.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run cargo xtask docgen and push the changes.

@pxhale
Copy link
Contributor Author

pxhale commented Oct 16, 2024

@adamperkowski I ran the command and committed the changes.

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torbrowser-launcher packages are not official. Some users might want to get tor browser directly. See https://support.torproject.org/apt/tor-deb-repo and https://support.torproject.org/rpm.

Co-authored-by: JEEVITHA KANNAN K S <ksjeevithakannan123@gmail.com>
@pxhale
Copy link
Contributor Author

pxhale commented Oct 17, 2024

@adamperkowski both instructions relate to only the tor package, not torbrowser-launcher

The torbrowser-launcher package seems to be maintained by the Tor project, see https://github.com/torproject/torbrowser-launcher

They also state that the packages in the distro's repos may be out-of-date and recommend installing torbrowser-launcher via Flatpak, see https://github.com/torproject/torbrowser-launcher?tab=readme-ov-file#installing-in-any-linux-distro-using-flatpak

Maybe it would be best to change the install script to use Flatpak instead of native package managers, what do you think?

@adamperkowski
Copy link
Collaborator

both instructions relate to only the tor package, not torbrowser-launcher

oh yeah.. sorry

Maybe it would be best to change the install script to use Flatpak instead of native package managers, what do you think?

I don't know. We try to avoid depending on flatpak as much as possible but this might be a good idea for distros like Debian.
Let's just keep the distro packages for now.

@adamperkowski adamperkowski changed the title Added Tor Browser to Web Browsers tab. feat: tor browser installation Oct 25, 2024
@ChrisTitusTech ChrisTitusTech merged commit f5f3824 into ChrisTitusTech:main Nov 7, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants