Skip to content

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Oct 17, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Changes made to the script

  • Use nala after installation.
  • Use nala fetch to get the fastest mirrors.
  • Removed redundant code of updates and upgrades.
  • Upgrade AUR packages also.
  • Simple update logic for flatpak apps.
  • The old $PACKAGER variable in the printf is actually not quoted.

Testing

  • Tested on arch system and debian12 VM with no issues.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2
Copy link
Contributor Author

jeevithakannan2 commented Oct 30, 2024

@adamperkowski 27ac253 please revert this commit if dnf is removed from fastupdate the wild card will be called. It will exit with no suitable packages manager. The --refresh was seperated as it will be easy to debug when an error occurs. Meaning it will be easier to identify if the error occured during refreshing of the mirrors or when updating the packages.

@adamperkowski adamperkowski force-pushed the system-update-refactor branch from 27ac253 to 2c72295 Compare October 30, 2024 02:52
@adamperkowski
Copy link
Collaborator

@jeevithakannan2 You're right here. Remember that it's your PR, you have full control over it.

@jeevithakannan2
Copy link
Contributor Author

@jeevithakannan2 You're right here. Remember that it's your PR, you have full control over it.

I am sure I didn't push that commit. It was authored by @Angxddeep and pushed by you.

@adamperkowski
Copy link
Collaborator

@jeevithakannan2 You're right here. Remember that it's your PR, you have full control over it.

I am sure I didn't push that commit. It was authored by @Angxddeep and pushed by you.

Yes it was. What I'm saying is you were able to revert it yourself. Sorry, should've asked you in the first place.

@jeevithakannan2
Copy link
Contributor Author

@jeevithakannan2 You're right here. Remember that it's your PR, you have full control over it.

I am sure I didn't push that commit. It was authored by @Angxddeep and pushed by you.

Yes it was. What I'm saying is you were able to revert it yourself. Sorry, should've asked you in the first place.

I am sorry for the hassle. I am not in my hometown and don't have my laptop with me. I am doing all the stuff with my mobile. That's why I asked you.

@adamperkowski
Copy link
Collaborator

@jeevithakannan2 You're right here. Remember that it's your PR, you have full control over it.

I am sure I didn't push that commit. It was authored by @Angxddeep and pushed by you.

Yes it was. What I'm saying is you were able to revert it yourself. Sorry, should've asked you in the first place.

I am sorry for the hassle. I am not in my hometown and don't have my laptop with me. I am doing all the stuff with my mobile. That's why I asked you.

No problem. Was not a hassle.

@ChrisTitusTech ChrisTitusTech merged commit da534df into ChrisTitusTech:main Nov 8, 2024
6 checks passed
@jeevithakannan2 jeevithakannan2 deleted the system-update-refactor branch November 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants