Skip to content

Replace BUILD_DATE with CARGO_PKG_VERSION #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Replace BUILD_DATE with CARGO_PKG_VERSION #878

merged 1 commit into from
Oct 31, 2024

Conversation

bmwiedemann
Copy link
Contributor

@bmwiedemann bmwiedemann commented Oct 27, 2024 •
edited
Loading

Replace BUILD_DATE with CARGO_PKG_VERSION
to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.

This is an alternative solution to #869

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Testing

Impact

Issues / other PRs related

  • Resolves #

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

adamperkowski
adamperkowski requested changes Oct 27, 2024
View reviewed changes
@adamperkowski
Copy link
Collaborator

Thanks for the PR. We can remove the whole build.rs file here and use CARGO_PKG_VERSION.

@bmwiedemann bmwiedemann force-pushed the datev2 branch 2 times, most recently from 0fd717e to 0f56d12 Compare October 27, 2024 13:06
@bmwiedemann bmwiedemann changed the title WIP: Replace BUILD_DATE with VERSION Replace BUILD_DATE with CARGO_PKG_VERSION Oct 27, 2024
@bmwiedemann bmwiedemann marked this pull request as ready for review October 27, 2024 15:04
adamperkowski
adamperkowski approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll close the other PR.

@adamperkowski adamperkowski mentioned this pull request Oct 27, 2024
Closed
12 tasks
@adamperkowski adamperkowski added the rust Pull requests that update Rust code label Oct 27, 2024
@lj3954
Copy link
Contributor

lj3954 commented Oct 27, 2024

The build dependency should also be removed.

@adamperkowski
Copy link
Collaborator

Oh yes. Liam is right.

@bmwiedemann
Replace BUILD_DATE with CARGO_PKG_VERSION
63436dc 
to make builds reproducible.
See https://reproducible-builds.org/ for why this is good.
@bmwiedemann
Copy link
Contributor Author

Is anything missing to get this merged?

adamperkowski
adamperkowski approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything missing to get this merged?

In this PR - no
In the repo - yes

Chris needs to set some things up

@ChrisTitusTech ChrisTitusTech merged commit b2fb332 into ChrisTitusTech:main Oct 31, 2024
2 checks passed
@jeevithakannan2 jeevithakannan2 mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmwiedemann @adamperkowski @lj3954 @ChrisTitusTech