Skip to content

Conversation

pik4li
Copy link
Contributor

@pik4li pik4li commented Oct 27, 2024

Type of Change

  • New feature

Description

Made the setup of Chris's dotfiles as an option, so that you can only install neovim and its dependencies

Testing

Changed the code -> save -> cargo run -> works

Impact

small

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@pik4li pik4li changed the title Made the neovim config setup as an option feat: neovim config setup as an option Oct 27, 2024
@adamperkowski
Copy link
Collaborator

adamperkowski commented Oct 27, 2024

I see where you're coming from but I'm not sure if we want this change. It may be better to just rename the entry from Neovim setup to something like Titus' Neovim setup

@adamperkowski adamperkowski changed the title feat: neovim config setup as an option feat: Titus' neovim config prompt Oct 27, 2024
pik4li and others added 2 commits October 27, 2024 23:35
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
@pik4li
Copy link
Contributor Author

pik4li commented Oct 27, 2024

I see where you're coming from but I'm not sure if we want this change. It may be better to just rename the entry from Neovim setup to something like Titus' Neovim setup

Thanks very much. Im pretty new to contributing, so any help is appreciated

@ChrisTitusTech
Copy link
Owner

Extra keypresses and prompts just annoy me. Going to deny this PR, if you are rolling your own neovim... why would you use mine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants