refact: Fix all shellcheck warnings + formatting

[jeevithakannan2]

Type of Change

• Refactoring

Description

• Fixes all the shellcheck warnings and formatting.
• @ChrisTitusTech I know this is a lot of file changes 99% of this is just formatting. No one was opening a PR for formatting and the shellcheck warning which causes the shellcheck workflow to fail. If you think you should do this no problem shfmt -i 4 -ci . at root for formatting.

Testing

• Tested arch server setup as it has some syntax changes.

Checklist

• My code adheres to the coding and style guidelines of the project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• My changes generate no errors/warnings/merge conflicts.

[ghost]

@jeevithakannan2 can you please stop spamming useless PRs such as this one?, the maintainer needs a break and he cant be merging every spam PR that you make !!

[ghost]

currently you have over 20 pull requests open ! that's ridiculous, not to mention that you had 38 open at one point. Seriously..

[ghost]

@ChrisTitusTech what are your opinions on this? i think this is just ridiculous at this point...

[ghost]

not to mention that this is highly likely to be untested. no way you ran 80+ scripts.

[ghost]

as Chris would say:

"Nuke the world PR, denied."

[ghost]

@jeevithakannan2 one question, is this tested? i assume that their is a 5% chance that you ran every script here to test your changes.

Who knows what syntax errors you could have caused in this pr.

[jeevithakannan2]

For your information shmft doesn't casues change that lead to syntax errors

[ghost]

Listen, I'm not here trying to argue with you, but if you're going to submit a PR that practically nukes the codebase with unnecessary formatting changes and also is untested, then I will argue with you because this is practically ridiculous.

[jeevithakannan2]

See if you have a problem with too many file changes you can go through them to see if there is anything suspicious. And 99% of them are just formatting with shfmt there is no need for testing this. As for syntax changes arch server setup was tested.

[ghost]

See if you have a problem with too many file changes you can go through them to see if there is anything suspicious. And 99% of them are just formatting with shfmt there is no need for testing this. As for syntax changes arch server setup was tested.

again you're violating this repos code of conduct.

[adamperkowski]

please test this

[adamperkowski]

what even are those changes man? why? i'm sorry but this looks so unnecessary and pointless to me.

[adamperkowski]

why are you unquoting a var in one case but quoting the same one in another? why deleting spaces between > and the target? why changing var names? and there's more. it almost looks like you want to artificially pump your line count. i'm sorry but i have to close this. you can redo this PR without all those changes.