Skip to content

Conversation

Jaredy899
Copy link
Contributor

@Jaredy899 Jaredy899 commented Dec 24, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Add Void Linux support for many applications, also utilizing my previous common-service-script.

Testing

Tested in Void Linux

Issues / other PRs related

Dependent on PR #985

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review December 24, 2024 13:32
@Jaredy899 Jaredy899 marked this pull request as draft December 24, 2024 13:35
@Jaredy899 Jaredy899 marked this pull request as ready for review December 24, 2024 13:36
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks OK. i know i'm asking for much but did you test every single thing that could break (more complex scripts) on a fresh installation? not approving for now.

@adamperkowski adamperkowski changed the title add Void linux support feat: Void linux support Jan 10, 2025
@adamperkowski adamperkowski added the enhancement New feature or request label Jan 10, 2025
@Jaredy899
Copy link
Contributor Author

I double checked everything and made some minor changes to ensure everything works smoothly. Ran on fresh void-xfce on proxmox. also made a change to the common-service-script as it wasn't working right with docker. But now it does.

runit)
"$ESCALATION_TOOL" mkdir -p "/run/runit/supervise.$1"
"$ESCALATION_TOOL" ln -sf "/etc/sv/$1" "/var/service/"
sleep 5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. why is it sleeping here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gives it time to set up the supervision. I had it set at 2 but it was failing. Seems to work at 5.

Copy link
Collaborator

@adamperkowski adamperkowski Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really like this approach to be honest. is there no other way? i don't understand the logic here.

Jaredy899 and others added 3 commits January 10, 2025 15:06
* chore: update copyright year (#988)

* refact: minor fixes (#971)

* Fix unused float handle mouse function, pub mod appstate

Fix unnecessary usage of pub mod for appstate and resolve unused float handle mouse function

* Resolve clippy warnings

Remove explicit lifetime for floatcontent impl. Use div_ceil instead of manually calculating the rows for hints

* chore(release): prepare for 25.1.10 (#991)

* Update linutil.yml (#993)

---------

Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
Co-authored-by: Jeevitha Kannan K S <ksjeevithakannan123@gmail.com>
Co-authored-by: Chris Titus <contact@christitus.com>
@Jaredy899 Jaredy899 closed this Jan 11, 2025
@Jaredy899 Jaredy899 deleted the Void branch January 11, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants