Skip to content

Conversation

Jaredy899
Copy link
Contributor

@Jaredy899 Jaredy899 commented Jan 12, 2025

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Tidy command no longer works for zypper. replaced with cleaning repos.

Testing

Tested in tumbleweed and leap.

Impact

Cleanup system

Issues / other PRs related

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@Jaredy899 Jaredy899 marked this pull request as ready for review January 12, 2025 04:41
@lj3954
Copy link
Contributor

lj3954 commented Jan 12, 2025

Does this work on older versions of the package manager as well?

@Jaredy899
Copy link
Contributor Author

Jaredy899 commented Jan 12, 2025

Tumbleweed is rolling release so if it's updated it works there. Leap 15.0 didn't work there. But it's 6 years old. Does work on Leap 15.2, 15.5 and 15.6. Also works on Suse linux enterprise 15.5 SP5.

@adamperkowski
Copy link
Collaborator

we could add a check for Leap 15.0 and older

@adamperkowski adamperkowski changed the title Fix zypper cleanup fix(system-cleanup): deprecated zypper tidy command Jan 16, 2025
@Jaredy899
Copy link
Contributor Author

I retested on a fresh proxmox vm with 15.0 and both commands do work. As far as I can see (and I'm new to suse so please correct me if I'm wrong), but it looks like tidy is a package you have to install?

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did compile-setup go?

@Jaredy899
Copy link
Contributor Author

It's in a different pr. Still trying to get the hang of doing prs

Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it for you :)

@ChrisTitusTech ChrisTitusTech merged commit a558f58 into ChrisTitusTech:main Jun 20, 2025
4 checks passed
@Jaredy899 Jaredy899 deleted the zypper branch June 20, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug- tidy command no longer works in zypper
5 participants