feat: export console issues #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
OrKoN
reviewed
Oct 31, 2025
Collaborator
|
There are conflicts with the main branch. Could you please rebase? |
OrKoN
reviewed
Nov 6, 2025
OrKoN
reviewed
Nov 6, 2025
nattallius
force-pushed
the
add-issues-export
branch
from
869a67c to
b05321d
Compare
added 7 commits
November 11, 2025 12:40
nattallius
force-pushed
the
add-issues-export
branch
from
9665ceb to
0a00958
Compare
OrKoN
reviewed
Nov 11, 2025
Collaborator
OrKoN
left a comment
OrKoN
left a comment
There was a problem hiding this comment.
Thanks! let's also add tests to make sure everything is working end-to-end and please address the lint and formatting issues.
| await this.#initializePage(page); | ||
| } | ||
|
|
||
| async #initializePage(page: Page) { |
Collaborator
There was a problem hiding this comment.
let's try to keep these methods sync and handle subscription asynchronously in the ConsoleCollector sub-class (e.g., void this.#subscribeToIssues()).
| this.storage.set(page, storedLists); | ||
|
|
||
| const listeners = this.#listenersInitializer(value => { | ||
| const collector = (value: T) => { |
Collaborator
There was a problem hiding this comment.
do we need changes here? can we change the emitting code to only emit issues once instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.