fix: forbid closing the last page #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/no-close-last-page
branch
from
a9caf20 to
2b3dc63
Compare
Collaborator
Author
|
@sebastianbenz would it be useful as an intermediate solution? |
OrKoN
force-pushed
the
orkon/no-close-last-page
branch
from
2b3dc63 to
02144e5
Compare
sebastianbenz
approved these changes
Sep 24, 2025
Collaborator
sebastianbenz
left a comment
sebastianbenz
left a comment
There was a problem hiding this comment.
Looks good. Wdyt about adding this to the tool description as well -> then it also makes sense to throw an error as the client is using it wrong.
OrKoN
force-pushed
the
orkon/no-close-last-page
branch
from
02144e5 to
7e73558
Compare
Collaborator
Author
|
Good idea, added. |
OrKoN
force-pushed
the
orkon/no-close-last-page
branch
from
7e73558 to
0574009
Compare
sebastianbenz
approved these changes
Sep 24, 2025
OrKoN
force-pushed
the
orkon/no-close-last-page
branch
from
0574009 to
cb253eb
Compare
OrKoN
pushed a commit
that referenced
this pull request
Sep 24, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.4](chrome-devtools-mcp-v0.2.3...chrome-devtools-mcp-v0.2.4) (2025-09-24) ### Bug Fixes * forbid closing the last page ([#90](#90)) ([0ca2434](0ca2434)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
OzTamir
pushed a commit
to OzTamir/chrome-devtools-mcp
that referenced
this pull request
Sep 25, 2025
McpContext currently assumes that there is a page. Eventually we might support closing the browser by closing the last page but right now we do not really have responses that indicate that the browser was closed. So this PR helps the LLM understand that it is okay to keep the last page running (and there are platform-specific differences as to what happens if the last page is closed). Ref ChromeDevTools#87
OzTamir
pushed a commit
to OzTamir/chrome-devtools-mcp
that referenced
this pull request
Sep 25, 2025
🤖 I have created a release *beep* *boop* --- ## [0.2.4](ChromeDevTools/chrome-devtools-mcp@chrome-devtools-mcp-v0.2.3...chrome-devtools-mcp-v0.2.4) (2025-09-24) ### Bug Fixes * forbid closing the last page ([ChromeDevTools#90](ChromeDevTools#90)) ([0ca2434](ChromeDevTools@0ca2434)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
McpContext currently assumes that there is a page. Eventually we might support closing the browser by closing the last page but right now we do not really have responses that indicate that the browser was closed. So this PR helps the LLM understand that it is okay to keep the last page running (and there are platform-specific differences as to what happens if the last page is closed).
Ref #87