feat(EXEC-5710): Add support for shallow checkout type
#376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uruemu
changed the title
shallow checkout type
uruemu
changed the title
shallow checkout typeshallow checkout type
| val.addDiagnostic(protocol.Diagnostic{ | ||
| Severity: protocol.DiagnosticSeverityError, | ||
| Range: step.Range, | ||
| Message: "Checkout depth must be a valid integer when using the shallow checkout method", |
There was a problem hiding this comment.
Suggested change
| Message: "Checkout depth must be a valid integer when using the shallow checkout method", | |
| Message: "Checkout depth is not an integer", |
There was a problem hiding this comment.
I recommend using the suggested message just to make the error a little clearer and to make the message easier to differentiate from the message we send when checkout depth is negative
parkuman
reviewed
Oct 15, 2025
There was a problem hiding this comment.
Would be nice to have this listed in the hover hints provided by schema.json
Also might be outside the scope, but now that we have a few methods for checkout, it would be cool to add it to the completion code so you can do CTRL+space when typing your checkout method and it lists the possible options for you. I think this is inside complete/steps.go somewhere
uruemu
force-pushed
the
uruemu/validate-shallow-checkout
branch
from
ae63a2d to
6a403a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://circleci.atlassian.net/browse/EXEC-5710
Important note : Release-please will only create a release PR for releases with a
featorfixcommit message. If your PR starts withchore, your changes will NOT be released.Description
Add
shallowcheckout method which requires a positivedepthvalue.How to validate
Unit tests: