-
Notifications
You must be signed in to change notification settings - Fork 7
Live Logging #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Logging #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements live logging functionality for model runner operations to improve observability and monitoring. The changes add structured timing measurements and status logging to track request performance across different model operation types.
- Adds comprehensive logging with timing, status codes, and request IDs to predict, generate, and stream operations
- Implements HTTP-style status code mapping (200 OK, 207 MIXED, 500 FAIL) for better readability
- Updates a test fixture configuration value from 1.33 to 1.3
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
clarifai/runners/models/model_runner.py |
Adds live logging with timing measurements and structured status reporting to all three runner methods |
tests/workflow/fixtures/single_branch_with_custom_cropper_model.yml |
Updates margin parameter from 1.33 to 1.3 in test fixture |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made suggestions on handling the status string codes. We can follow same for generate and stream.
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Live Logging * Live logging and patch signature in local-runner * Fix patching model signature * Improve logging * Remove patch signatures * fix edge case * fix test * handle edge case * status in constant file
Pull Request Overview
This PR implements live logging functionality for model runner operations to improve observability. The changes add structured logging that tracks request timing, status codes, and request IDs for better monitoring of model prediction, generation, and streaming operations.