Skip to content

[EAGLE-6460]: Add func to return both stub and channel. #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

[EAGLE-6460]: Add func to return both stub and channel. #713

merged 2 commits into from
Jul 22, 2025

Conversation

patricklundquist
Copy link
Contributor

Why

  • Needed for base runner to manage closing the channel for reconnects.

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
clarifai 43% ❌
clarifai.cli 42% ❌
clarifai.cli.templates 28% ❌
clarifai.client 69% ➖
clarifai.client.auth 67% ➖
clarifai.constants 100% ✔
clarifai.datasets 100% ✔
clarifai.datasets.export 80% ✔
clarifai.datasets.upload 75% ➖
clarifai.datasets.upload.loaders 37% ❌
clarifai.models 100% ✔
clarifai.modules 0% ❌
clarifai.rag 72% ➖
clarifai.runners 11% ❌
clarifai.runners.models 59% ➖
clarifai.runners.pipeline_steps 45% ❌
clarifai.runners.pipelines 85% ✔
clarifai.runners.utils 62% ➖
clarifai.runners.utils.data_types 72% ➖
clarifai.schema 100% ✔
clarifai.urls 60% ➖
clarifai.utils 53% ➖
clarifai.utils.evaluation 67% ➖
clarifai.workflows 95% ✔
Summary 62% (7368 / 11894) ➖

Minimum allowed line rate is 50%

@patricklundquist patricklundquist merged commit cee16f2 into master Jul 22, 2025
11 checks passed
@patricklundquist patricklundquist deleted the fix-grpc-hang branch July 22, 2025 20:08
srikanthbachala20 pushed a commit that referenced this pull request Jul 23, 2025
@patricklundquist @srikanthbachala20
[EAGLE-6460]: Add func to return both stub and channel. (#713)
cbed4cb 
* Add func to return both stub and channel.

* tidy
srikanthbachala20 added a commit that referenced this pull request Jul 23, 2025
@Copilot @srikanthbachala20
@luv-bansal @mogith-pn @patricklundquist
Add CLI config context support to BaseClient authentication (#704)
716186f 
* Initial plan

* Implement CLI config context fallback in BaseClient

Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>

* Remove tests/test_base_client_cli_config.py file as requested

Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>

* Remove tests/test_misc_cli_config.py as requested

Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>

* [PR-725]: Using Config Context in Baseclient class

* Improve error message formatting and clarity in authentication

Co-authored-by: luv-bansal <70321430+luv-bansal@users.noreply.github.com>

* Add github folder download support and toolkit option in model init (#699)

* added github folder download support

* modified folder structure validation

* supported toolkit options for ollama

* fixed param name and toolkit bugs

* removed print in misc.py

* updated with log and raise

* Update clarifai/utils/misc.py

Co-authored-by: Srikanth Bachala <srikanth.bachala@clarifai.com>

---------

Co-authored-by: Srikanth Bachala <srikanth.bachala@clarifai.com>

* Improve client script formatting (black linter formatting) and added logger once runner start (#705)

* VERSION-11.5.5

* Black linter to fix stylistic issues and ensure it follows to common Python standards

* better representation

* fix formatting

* fix formatting

* fix formatting

* [PR-727]: Improve Local-Runner CLI Logging (#706)

* [PR-727]: Improve Local-Runner CLI Logging

* [PR-727]: Improve Local-Runner CLI Logging

* [PR-727]: Improve Local-Runner CLI Logging

* [PR-727]: Improve Local-Runner CLI Logging

* PR-323 Unit tests for toolkits. (#639)

* added initial vllm unit tests

* modified permissions for maintainer_tests.yml

* modified yaml file

* removed codecoverage for maintainer tests

* modified env vars for tests

* added labels to tests

* removed inputs in workflow disptach

* added pytest.ini

* removed unused functions

* added --enforce-eager option

* removed redundant URL logging

* Added Playground URL to Local-Runner Logs (#708)

* [PR-733] Improve URL Download error handling (#710)

* Improve error handling

* Improve error handling

* Improve error handling

* Added local-runner requirements validation step (#712)

* added local-runner requirements validation step

* added post check for ollama toolkit

* fixed tests

* [EAGLE-6460]:  Add func to return both stub and channel. (#713)

* Add func to return both stub and channel.

* tidy

* [PR-739] [PR-740] Unify Context Management Under a Single config Command (#709)

* Unify Context Management Under a Single context Command

* login func

* improvemensts and fix tests

* better alias

* active to current

* Unify config

* Update readme

* fix test

* update readme

* update readme

* update readme

* add set-context alias

* Initial plan

* [PR-725]: Using Config Context in Baseclient class

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>
Co-authored-by: Srikanth Bachala <srikanth.bachala@clarifai.com>
Co-authored-by: luv-bansal <70321430+luv-bansal@users.noreply.github.com>
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Co-authored-by: Patrick Lundquist <1460278+patricklundquist@users.noreply.github.com>
@luv-bansal luv-bansal mentioned this pull request Jul 23, 2025
Merged
srikanthbachala20 pushed a commit that referenced this pull request Jul 29, 2025
@patricklundquist @srikanthbachala20
[EAGLE-6460]: Add func to return both stub and channel. (#713)
d1a7981 
* Add func to return both stub and channel.

* tidy
srikanthbachala20 added a commit that referenced this pull request Jul 29, 2025
@Copilot @srikanthbachala20
@luv-bansal @mogith-pn @patricklundquist
Add CLI config context support to BaseClient authentication (#704)
ab7ef18 
* Initial plan

* Implement CLI config context fallback in BaseClient

Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>

* Remove tests/test_base_client_cli_config.py file as requested

Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>

* Remove tests/test_misc_cli_config.py as requested

Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>

* [PR-725]: Using Config Context in Baseclient class

* Improve error message formatting and clarity in authentication

Co-authored-by: luv-bansal <70321430+luv-bansal@users.noreply.github.com>

* Add github folder download support and toolkit option in model init (#699)

* added github folder download support

* modified folder structure validation

* supported toolkit options for ollama

* fixed param name and toolkit bugs

* removed print in misc.py

* updated with log and raise

* Update clarifai/utils/misc.py

Co-authored-by: Srikanth Bachala <srikanth.bachala@clarifai.com>

---------

Co-authored-by: Srikanth Bachala <srikanth.bachala@clarifai.com>

* Improve client script formatting (black linter formatting) and added logger once runner start (#705)

* VERSION-11.5.5

* Black linter to fix stylistic issues and ensure it follows to common Python standards

* better representation

* fix formatting

* fix formatting

* fix formatting

* [PR-727]: Improve Local-Runner CLI Logging (#706)

* [PR-727]: Improve Local-Runner CLI Logging

* [PR-727]: Improve Local-Runner CLI Logging

* [PR-727]: Improve Local-Runner CLI Logging

* [PR-727]: Improve Local-Runner CLI Logging

* PR-323 Unit tests for toolkits. (#639)

* added initial vllm unit tests

* modified permissions for maintainer_tests.yml

* modified yaml file

* removed codecoverage for maintainer tests

* modified env vars for tests

* added labels to tests

* removed inputs in workflow disptach

* added pytest.ini

* removed unused functions

* added --enforce-eager option

* removed redundant URL logging

* Added Playground URL to Local-Runner Logs (#708)

* [PR-733] Improve URL Download error handling (#710)

* Improve error handling

* Improve error handling

* Improve error handling

* Added local-runner requirements validation step (#712)

* added local-runner requirements validation step

* added post check for ollama toolkit

* fixed tests

* [EAGLE-6460]:  Add func to return both stub and channel. (#713)

* Add func to return both stub and channel.

* tidy

* [PR-739] [PR-740] Unify Context Management Under a Single config Command (#709)

* Unify Context Management Under a Single context Command

* login func

* improvemensts and fix tests

* better alias

* active to current

* Unify config

* Update readme

* fix test

* update readme

* update readme

* update readme

* add set-context alias

* Initial plan

* [PR-725]: Using Config Context in Baseclient class

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: srikanthbachala20 <170492893+srikanthbachala20@users.noreply.github.com>
Co-authored-by: Srikanth Bachala <srikanth.bachala@clarifai.com>
Co-authored-by: luv-bansal <70321430+luv-bansal@users.noreply.github.com>
Co-authored-by: mogith-pn <143642606+mogith-pn@users.noreply.github.com>
Co-authored-by: Patrick Lundquist <1460278+patricklundquist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeiler zeiler zeiler approved these changes

@luv-bansal luv-bansal Awaiting requested review from luv-bansal

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patricklundquist @zeiler