Skip to content

Remove generative=True #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2025

Conversation

OriRothClassiq
Copy link
Member

PR Description

Some notes

  • Please make sure that the notebook runs successfully with the latest Classiq version.

  • Please make sure that you placed the files in an appropriate folder

    • And that the file names are clear, descriptive, and match the notebook content.
      • Note that we require the file names of .ipynb and .qmod to be unique across this repository.
    • Plus, please make sure that all required files are included: .qmod, .synthesis_options.json, .metadata.json
    • And that images are embedded inside the notebook, not added as external files
  • If applicable, please include link to the paper on which the notebook is based, in the notebook itself.

  • Please use rebase on your branch (no merge commits)

  • Please link this PR to the relevant issue

  • Please make sure to run pre-commit when commiting changes

    • If you're using git in the terminal, make sure to install pre-commit via running pip install pre-commit followed by pre-commit install
    • Note that Classiq runs automatic code linting. Meaning that one of the tests verifies the output of pre-commit.
    • Also note that pre-commit may minorly alter some files. Make sure to git add the changes done by pre-commit

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@OriRothClassiq
Copy link
Member Author

/rebase

@OriRothClassiq OriRothClassiq force-pushed the Model/OriRothClassiq/update-generative-True branch 5 times, most recently from c8d9ecc to c60bde7 Compare April 30, 2025 09:25
@OriRothClassiq OriRothClassiq force-pushed the Model/OriRothClassiq/update-generative-True branch from c60bde7 to 6db1f49 Compare April 30, 2025 09:29
@OriRothClassiq OriRothClassiq requested review from orsa-classiq and TomerGoldfriend and removed request for orsa-classiq April 30, 2025 09:59
@OriRothClassiq OriRothClassiq merged commit 9b90f74 into main May 4, 2025
2 checks passed
@OriRothClassiq OriRothClassiq deleted the Model/OriRothClassiq/update-generative-True branch May 4, 2025 07:04
Copy link

github-actions bot commented May 4, 2025

👏 Incredible, @OriRothClassiq! You've merged your 14th PR! 🎯🎊

Your ongoing commitment to classiq-library is truly remarkable. You're a driving force in our community! 🚀
Your contributions are helping to shape the future of quantum computing! What exciting features or improvements do you envision next? 🔮

We are grateful for your dedication! 💫

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants