Fix new region settings/overlay finalize order (#83146)

* fix Magiclysm region overlay typo

* swap new region settings/overlay finalization order

Author: ShnitzelX2

data/mods/Magiclysm/worldgen/regional_overlay.json

@@ -5,7 +5,8 @@
     "apply_to_tags": [ "all" ],
     "cities": "default_magiclysm",
     "map_extras": "default_magiclysm",
-    "terrain_furniture": "default_magiclysm"
+    "terrain_furniture": "default_magiclysm",
+    "forest_composition": "default_magiclysm"
   },
   {
     "type": "region_settings_city",
@@ -122,6 +123,11 @@
     "overlay_id": "forest_thick",
     "extras": [ [ "mx_catoblepas_lair", 1 ] ]
   },
+  {
+    "type": "region_settings_forest_mapgen",
+    "id": "default_magiclysm",
+    "biomes": [ "biome_forest_thick_default_magiclysm" ]
+  },
   {
     "type": "forest_biome_mapgen",
     "id": "biome_forest_thick_default_magiclysm",

src/init.cpp

@@ -896,8 +896,8 @@ void DynamicDataLoader::finalize_loaded_data()
             { _( "Proficiency Categories" ), &proficiency_category::finalize_all },
             { _( "Qualities" ), &quality::finalize_all },
             { _( "Recipe Groups" ), &recipe_group::finalize },
-            { _( "Region Settings" ), &region_settings::finalize_all },
             { _( "Region Overlays" ), &region_overlay_new::finalize_all },
+            { _( "Region Settings" ), &region_settings::finalize_all },
             { _( "Relic Procedural Generations" ), &relic_procgen_data::finalize_all },
             { _( "Speed Descriptions" ), &speed_description::finalize_all },
             { _( "Species" ), &species_type::finalize_all },

src/regional_settings.h

@@ -885,6 +885,7 @@ struct region_settings {
 * To solve this, we apply region_overlay.
 *
 * region_overlay should NEVER redefine or remove elements from a given setting!
+* overlays must always be applied before region_settings::finalize_all
 */
 struct region_overlay_new {
     region_overlay_new_id id = region_overlay_new_id::NULL_ID();