Skip to content

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

I remembered a while ago i wished i didn't need to drag all the stuff to the trader, and just sell stuff directly from my car
Today i suddenly realised i can do it

Describe the solution

Make exactly it, if car is within the reality bub and your faction own it, all it's cargo is part of a trading UI

Describe alternatives you've considered

Highlight them somehow? I assume it won't be really possible without some invasive changes

Testing

Testing with anvils
Before:
image

After:
image

Stuff is properly sold, properly disappear from the vehicle, and properly appear in trader storages

Additional context

I would like stuff being combined in this menu, but i could not find the function needed

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 2, 2025
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 3, 2025
@PatrikLundell
Copy link
Contributor

Have you tested multiple of your vehicles (somewhat plausible scenarion: you arrive at a roaming trader's location, find hostiles, unload your motorbike from your vehicle's bike racks, kill off the enemies and load their stuff into the cargo space of your MC, and then proceed to trade)?

Also, it can be an absolutely massive amount of stuff if you bring a vehicle with a lot of cargo space with you (also, I have one tile of my vehicle reserved for stuff I want to have with me to be at hand, but not lug around, and so have stuff I don't want to trade).

@GuardianDll
Copy link
Member Author

GuardianDll commented Oct 3, 2025

The code should work with infinite amount of vehicles, as long as they are part of your faction
Excluding items is something i thought about, but didn't figure a good way to do it

@Maleclypse Maleclypse merged commit ee1aec0 into CleverRaven:master Oct 4, 2025
37 of 38 checks passed
@GuardianDll GuardianDll deleted the stuff_inside_cars_is_tradeable branch October 4, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants