Skip to content

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Oct 3, 2025

Summary

Mods "[Sky Island] Fix Evict hostiles interacting with normally-unkillable monsters exp "

Purpose of change

Getting infinite XP from killing one Person in Sky Island trivializes Bombastic Perks and Martial Mastery,

Describe the solution

Change Evict Hostiles so it evokes u_die, and thus the creature that dies does not have an assigned killer.

Describe alternatives you've considered

Testing

Kill a Person, did not gain millions of XP.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Sky Island Anything about the Sky Island mod json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 3, 2025
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine.

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Oct 3, 2025

Also fine.

Like you said, it's not a bug, but I doubt it's intended.

Edit: Maybe I should just pull the trigger on turning off portal storms while you're on your island, since there's already a bunch of infrastructure to make them and all their effects go away while you're up there.

@SariusSkelrets
Copy link
Contributor

Eviction granting XP is totally unintended and I planned to fix it as soon as I could when I saw the bug report. Thanks for fixing it.

Don't forget to make the u_die remove the corpse and don't leave a message about the target dying. It's the island sending them to nobody-knows-where, not you killing them. It's also intended that you lose on loot when using it, so you don't try to bring foes home to kill them for their stuff.

I plan to make portal storms not happen while on the island and interrupted by the player returning by any means. The island is intended to be safe and the player now has tools to make sure it stays that way.

It'll pave the way to the first Sky Island challenge upgrade, where players can heighten difficulty for shards if they survive: start at the start and center of a portal storm.

@Standing-Storm
Copy link
Contributor Author

so you don't try to bring foes home to kill them for their stuff.

Is that actually possible?

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 3, 2025
@SariusSkelrets
Copy link
Contributor

Is that actually possible?

Sky Island allows to craft an item that can be used to capture creatures of any size. The code says that this capture action has a flat 1/10 chance to work against full-hp enemies and gets higher the more injured the enemy is.

So yes, it is in fact possible. Not likely nor practical, but possible.

@Maleclypse Maleclypse merged commit 21c55b4 into CleverRaven:master Oct 4, 2025
28 checks passed
@Standing-Storm Standing-Storm deleted the neutral-eviction branch October 5, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants