Skip to content

Adding more nuanced split method and tests #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2024
Merged

Adding more nuanced split method and tests #416

merged 2 commits into from
Jul 22, 2024

Conversation

Paultagoras
Copy link
Contributor

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras self-assigned this Jul 19, 2024
@Paultagoras Paultagoras merged commit 3b4015c into main Jul 22, 2024
@Paultagoras Paultagoras deleted the fix-comma-column-name branch July 22, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chernser chernser chernser approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

@BentsiLeviav BentsiLeviav Awaiting requested review from BentsiLeviav

Assignees

@Paultagoras Paultagoras

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paultagoras @chernser