Skip to content

Conversation

chernser
Copy link
Contributor

Summary

Added initial project for the benchmark

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials
image

@chernser chernser requested review from mzitnik and mshustov July 31, 2025 18:24
Copy link
Collaborator

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points

  • Can we convert it to be a module in the project so we could use the gradle directory
  • The code that creates data seems to identical to what we have in tests can we use it as a module

@chernser
Copy link
Contributor Author

chernser commented Aug 5, 2025

I've done JMH as separate project because:

  1. It is a completely separate application
  2. I do want to split builds of main application and this one.

I agree that we need to reuse test classes. For that I will repeat what is done in clickhouse-java and will create a test classes jar.

@chernser chernser requested a review from mzitnik August 23, 2025 15:38
Copy link
Collaborator

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add to the contribution guide on how to run it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants