Feat/add settings to write (#3) #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahdimalverdi
commented
Dec 21, 2024
mahdimalverdi
commented
- Support ClickHouse insert settings for table writes (Support to set ClickHouse insert settings when writing to a table #369)
* Support ClickHouse insert settings for table writes (ClickHouse#369) - Enable custom ClickHouse insert settings when writing to tables. - Add support for `spark.clickhouse.write.settings` configuration. - Update documentation to describe usage of write settings. Closes ClickHouse#369 * reformat the codes Closes ClickHouse#369 --------- Co-authored-by: Mahdi Malverdi <malverdi@yektanet.ir>
|
@mahdimalverdi can you provide tests for the new feature |
|
i write tests for this as soon as possible. |
|
@mahdimalverdi did you manage to get the tests written for this? |
Apologies, but I don’t think I’ll be able to dedicate time to this merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.