Adding some helpful changes #981
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetteriM1
reviewed
Nov 28, 2019
| this.craftingType = CRAFTING_SMALL; | ||
|
|
||
| // adding command execution like in Nukkit-DOC -> see above | ||
| if(message.startsWith("/")) { |
Author
There was a problem hiding this comment.
i just think player.chat("/say hi"); is better and faster written then player.getServer().dispatchCommand(player, "say hi"); and its written in the javadoc if a message starts with / in player.chat method it would be dispatched as command... :)
Member
There was a problem hiding this comment.
That doc comment looks like a mistake when commands were given their own packet in 1.2
KCodeYT
pushed a commit
to KCodeYT/Nukkit
that referenced
this pull request
May 29, 2021
…ages Fixes CloudburstMC#981 magma, lava, and starvation death messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding * // negative permission for * users to remove solo perms from *
Adding getNearbyEntities // getNearbyPlayers methods to player object
Adding Command-executor to player.chat() method ( if message starts with a / ) like in DOCs described