Skip to content

Migrate svelte5 #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

Migrate svelte5 #393

wants to merge 33 commits into from

Conversation

spacehamster87
Copy link
Contributor

@spacehamster87 spacehamster87 commented May 13, 2025

See Issue #359

This PR updates Svelte frontend dependencies to Svelte 5 using the frameworks backwards-combatibility

This means, most Svelte 4 syntax works, but future development can now use Svelte 5 syntax as well [Non-Working Snippets are fixed in this PR].

Complete migration before merge not recommendend, as it works better as a iterative process.

Opened as draft PR due to some open issues while compiling, even if the app works fine afterwards, namely:

  • Style Warnings for imported Sveltestrap Components (once) during compilation
    • Update: Warnings set to be ignored in rollup config
  • Circular Dependency Warnings during compilation (Cause TBD)
    • Update: Open Issue exists in Svelte 5 Repo, no solution so far. Warnings clutter compilation logs, but are otherwise harmless.

Update 5.6.2025

Migration of several components was required to fix several functionality problems after initial "backwards-compatible" migration attempt.

@spacehamster87
Copy link
Contributor Author

  • Sveltestrap Warning on Compilation: Filtered via Rollup Config
  • Circular Dependencies: Known Issue (see here)
    • Consent so far: No functional implications, "just annoying" (see for example here, second bullet point)

@spacehamster87
Copy link
Contributor Author

Checkpoint: In local test environment all functionality is restored, smaller pre-existing issues fixed additionally, e.g.:

  • spacing and layout in jobList toolbar
  • in continuous jobList, refreshing repeatedly added jobs to view
  • user and project list sorting

Next Step: Merge updated dev branch into migration branch and solve issues if any

@spacehamster87 spacehamster87 marked this pull request as ready for review June 6, 2025 15:59
@spacehamster87
Copy link
Contributor Author

No other issues found locally. I will test further still, but the PR can me marked as ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant