-
Notifications
You must be signed in to change notification settings - Fork 16
Migrate svelte5 #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spacehamster87
wants to merge
33
commits into
dev
Choose a base branch
from
migrate_svelte5
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate svelte5 #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated all dependencies - removed svelte-chartjs wrapper from dependencies - sveltestrap causes compilation warnings (once) - Header.svelte uses new Svelte5 syntax as example - fixed most initial compilation warnings except circular dependencies with TBD cause
- fixes event_handler_invalid svelte warning and blockage
- allowed setting wrong field
- missing autocomplete attribute was logged as warning in chrome console
- filters now inactive in user jobs, lists and analysis due to missing dispatch
Checkpoint: In local test environment all functionality is restored, smaller pre-existing issues fixed additionally, e.g.:
Next Step: Merge updated dev branch into migration branch and solve issues if any |
No other issues found locally. I will test further still, but the PR can me marked as ready to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #359
This PR updates Svelte frontend dependencies to Svelte 5 using the frameworks backwards-combatibilityThis means, most Svelte 4 syntax works, but future development can now use Svelte 5 syntax as well [Non-Working Snippets are fixed in this PR].Complete migration before merge not recommendend, as it works better as a iterative process.Opened as draft PR due to some open issues while compiling, even if the app works fine afterwards, namely:
Update 5.6.2025
Migration of several components was required to fix several functionality problems after initial "backwards-compatible" migration attempt.