Skip to content

Support criterion benchmark group displays #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EYHN opened this issue Sep 21, 2023 · 1 comment
Open

Support criterion benchmark group displays #20

EYHN opened this issue Sep 21, 2023 · 1 comment

Comments

@EYHN
Copy link

EYHN commented Sep 21, 2023

First of all I would like to thank you for making such a good benchmark action, which is almost the only well-functioning and well-maintained benchmark action on github. 🙏 🎉

I have a benchmark that uses criterion benchmark_group to compare multiple functions, for example I have the following benchmark code:

let mut group = c.benchmark_group("Map Insert");
group.bench_function("HashMap", |b| {
    ...
});
group.bench_function("BTreeMap", |b| {
    ...
});

When I run the benchmark locally, I can see in the console that the benchmark's name is a combination of the group's name and the function's name.

Map Insert/HashMap      time:   [275.12 ns 284.51 ns 293.79 ns]
Map Insert/BTreeMap     time:   [418.15 ns 424.73 ns 431.82 ns]

However, when running in codspeed, the result is only the function name, without the group name, which makes it difficult to compare.

图片
@art049 art049 changed the title criterion benchmark group displays do not meet expectations Support criterion benchmark group displays Apr 24, 2024
@art049 art049 changed the title Support criterion benchmark group displays Support criterion benchmark group displays Sep 4, 2024
@ctz
Copy link

ctz commented Oct 12, 2024

Having just got started with codspeed (having learned about it at eurorust this week) I have the same experience.

eg, compare https://codspeed.io/ctz/graviola/benchmarks and https://jbp.io/graviola/reports/x86_64/report/index.html (from the same set of benchmark code)

@art049 art049 added the UX label Dec 17, 2024 — with Linear
@art049 art049 removed the UX label Mar 3, 2025
@art049 art049 added the UX label Mar 3, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants