Skip to content

Default to --profile bench? #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaniPopes opened this issue Dec 12, 2024 · 3 comments
Open

Default to --profile bench? #60

DaniPopes opened this issue Dec 12, 2024 · 3 comments

Comments

@DaniPopes
Copy link

DaniPopes commented Dec 12, 2024

cargo codspeed build defaults to --profile release, vs cargo bench/cargo criterion defaulting to --profile bench. Bench inherits release by default but it can be overridden for e.g. adding more debug info to it compared a normal release build. Is this intentional? Thanks

@DaniPopes DaniPopes changed the title Default to bench? Default to --profile bench? Dec 12, 2024
@art049
Copy link
Member

art049 commented Dec 13, 2024

Yes, this is intentional. The bench profile comes with undocumented limitations regarding custom build processes.
Completely agree this should be the default behavior when this is possible.
(I don't remember the details of the experiment showing the limitations, though).

Did passing --profile bench work for you?

@DaniPopes
Copy link
Author

Yes, --profile bench works

Copy link
Member

art049 commented Dec 20, 2024

Okay then definitely it would make sense to include this in the next major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants