Skip to content

Support pytest-benchmark marker attributes #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

art049
Copy link
Member

@art049 art049 commented May 31, 2025

No description provided.

@art049 art049 force-pushed the cod-949-support-pytest-benchmark-marker-attributes branch from cb03c07 to 51d2adb Compare June 1, 2025 12:39
Copy link

codspeed-hq bot commented Jun 1, 2025

CodSpeed Instrumentation Performance Report

Merging #80 will not alter performance

Comparing cod-949-support-pytest-benchmark-marker-attributes (22d4d33) with master (7583000)

Summary

✅ 57 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 1, 2025

CodSpeed Walltime Performance Report

Merging #80 will degrade performances by 8.69%

Comparing cod-949-support-pytest-benchmark-marker-attributes (22d4d33) with master (7583000)

Summary

⚡ 4 improvements
❌ 18 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iir_filter_process 3 µs 3.1 µs -2.84%
test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 848.9 ns 876.6 ns -3.15%
test_color[graph0-3] 29 µs 29.8 µs -2.74%
test_combination_sum[candidates0-8] 10.6 µs 11 µs -3.05%
test_depth_first_search[4] 31.3 µs 30.2 µs +3.81%
test_generate_all_combinations[4-2] 6.8 µs 7.1 µs -3.93%
test_generate_all_permutations[sequence1] 158 µs 162.2 µs -2.57%
test_generate_sum_of_subsets_soln[nums0-9] 23.6 µs 24.4 µs -3.04%
test_get_valid_pos[pos0-4] 2.8 µs 2.9 µs -5.08%
test_is_safe[board0-1-1] 10.7 µs 10.4 µs +3.11%
test_minimax[scores0] 10.4 µs 10.6 µs -2.12%
test_open_knight_tour[1] 3.7 µs 3.6 µs +2.21%
test_solve_crossword[puzzle0-words0] 2.3 µs 2.1 µs +5.58%
test_solve_maze[maze0] 23.1 µs 23.7 µs -2.18%
test_sudoku[initial_grid0] 7.9 µs 8.1 µs -2.46%
test_recursive_fibo_10 39.9 µs 41.4 µs -3.84%
test_recursive_fibo_20 4.8 ms 5 ms -4.27%
test_count_even[count_even_slow] 1.4 ms 1.5 ms -5.9%
test_sum_of_squares[sum_of_squares_sum_comprehension_power] 217.9 µs 238.6 µs -8.69%
test_sum_of_squares[sum_of_squares_sum_comprehension_product] 187.7 µs 201.9 µs -7.01%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@art049 art049 requested a review from adriencaccia June 3, 2025 08:52
Copy link
Member

@adriencaccia adriencaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I am curious to know if there will be type hinting when using @pytest.mark.codspeed_benchmark(...)?

For the docs, you plan to do it on docs.codspeed.io right?

@art049 art049 force-pushed the cod-949-support-pytest-benchmark-marker-attributes branch from da343e2 to d3009ea Compare June 3, 2025 09:01
@art049
Copy link
Member Author

art049 commented Jun 3, 2025

Unfortunately, no type hints will be available :(

Yep the docs will be on the docs website

@art049 art049 force-pushed the cod-949-support-pytest-benchmark-marker-attributes branch from d3009ea to 84605a0 Compare June 6, 2025 08:53
@art049 art049 force-pushed the cod-949-support-pytest-benchmark-marker-attributes branch from 84605a0 to 22d4d33 Compare June 6, 2025 09:17
@art049 art049 merged commit 22d4d33 into master Jun 6, 2025
25 checks passed
@art049 art049 deleted the cod-949-support-pytest-benchmark-marker-attributes branch June 6, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants