-
Notifications
You must be signed in to change notification settings - Fork 344
Add sign out confirmation modal #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Zunairah-k is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
@Avdhesh-Varshney please review and merge when possible |
* base server with ts setup * setup schemas * setup modals * config files setup * routes setup * setup middlewares * apis setup * fixes: collection apis * fixes: collaborator apis * renamed * remove nodemon * restructure * update collection apis * update request methods * update req method * add mongoose types * deploy issue fixed * refix deploy * build fix * new-collection-route
@Avdhesh-Varshney please review |
4c6c69d
to
f695d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to review. Could you just commit only your changes and not anything un-necessary?
@Avdhesh-Varshney i only commited the changes that i made in the files to add that confirmation modal. could you tell me what's blocking the review further? |
7446ed0
to
f368eb7
Compare
Hi @Zunairah-k, I've recently take a major change in repo by transforming the whole FE from JS to TS. So, you need to raise a new fresh PR in Earlier one version is deleted and current TS version is not stable right now exactly. But we're working on it. Thanks 👍 |
@Avdhesh-Varshney since the new TS version isn’t fully stable yet, should I go ahead and re-implement my changes in client/ and open a fresh PR now, or would you prefer I wait until you guys finish stabilizing it? |
Really appreciate your interest! So, Wait for some time for this feature implementation. Thanks!
|
Closes: #1224
PR Description
Screenshots 📷
Type of change ☑️
Note to reviewers