Skip to content

Conversation

Zunairah-k
Copy link
Contributor

Closes: #1224

PR Description

  • Added a Sign Out Confirmation modal in the User Navigation Panel.
  • The modal is functional and shows when the Sign Out button is clicked.
  • Supports light mode and dark mode, with improved visibility and styling.
  • Modal contains Cancel and Sign Out buttons that behave correctly:
    • Cancel closes the modal.
    • Sign Out removes user session and logs the user out.
  • Added basic styling effects for the modal (shadows, rounded corners, and backdrop blur).
  • Replaced the old sign out button behavior that immediately logged out the user.

Screenshots 📷

  • Light Mode:
{671B022F-B492-422A-8A21-1AE310EBD4CA}
  • Dark Mode:
image

Type of change ☑️

  • Bug fix
  • New feature
  • Code style update (formatting, local variables)
  • Documentation update
  • Database update

Note to reviewers

  • Tested manually on both light and dark mode.
  • Verified that the modal opens and closes correctly.
  • Verified that Sign Out removes user session and updates UI.
  • Modal styling ensures readability in both themes.

Copy link

vercel bot commented Sep 22, 2025

@Zunairah-k is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Zunairah-k
Copy link
Contributor Author

@Avdhesh-Varshney please review and merge when possible

Avdhesh-Varshney and others added 2 commits September 27, 2025 19:50
* base server with ts setup

* setup schemas

* setup modals

* config files setup

* routes setup

* setup middlewares

* apis setup

* fixes: collection apis

* fixes: collaborator apis

* renamed

* remove nodemon

* restructure

* update collection apis

* update request methods

* update req method

* add mongoose types

* deploy issue fixed

* refix deploy

* build fix

* new-collection-route
@Zunairah-k
Copy link
Contributor Author

@Avdhesh-Varshney please review

Copy link
Member

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to review. Could you just commit only your changes and not anything un-necessary?

@Zunairah-k
Copy link
Contributor Author

@Avdhesh-Varshney i only commited the changes that i made in the files to add that confirmation modal. could you tell me what's blocking the review further?

@Avdhesh-Varshney
Copy link
Member

Hi @Zunairah-k, I've recently take a major change in repo by transforming the whole FE from JS to TS. So, you need to raise a new fresh PR in client folder.

Earlier one version is deleted and current TS version is not stable right now exactly. But we're working on it. Thanks 👍

@Zunairah-k
Copy link
Contributor Author

@Avdhesh-Varshney since the new TS version isn’t fully stable yet, should I go ahead and re-implement my changes in client/ and open a fresh PR now, or would you prefer I wait until you guys finish stabilizing it?

@Avdhesh-Varshney
Copy link
Member

Really appreciate your interest!
But it might be taking some time in stabilization of FE as the current codebase is larger and not easy to maintain solely.

So, Wait for some time for this feature implementation.

Thanks!

I would like to invite you in this process. This will definitely be a learning experience for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Confirmation Modal for Sign Out Action

2 participants