Skip to content

Feature/backend/list of collaborators #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Feature/backend/list of collaborators #1244

wants to merge 7 commits into from

Conversation

vansh909
Copy link
Contributor

Closes: #1193

Describe the add-ons or changes you've made 📃

  • Implemented a new API endpoint to fetch the list of collaborators for a project.
  • The API ensures only authorized user (project owner) can access this information.
  • The response returns the list of collaborators.
  • Added proper error handling for scenarios like missing or invalid project IDs.

Type of change ☑️

What sort of change have you made:

  • New feature

Note to reviewers 📄

  • Feature developed as part of the Invite Multiple Collaborators to a Project task.
  • Please verify the endpoint security and response format during review.

@vercel Vercel
Copy link

vercel bot commented Sep 22, 2025

@vansh909 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Avdhesh-Varshney
Avdhesh-Varshney requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After doing all the changes, plz share a working video of postman with that api

backend/Routes/index.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changes from this file

backend/Routes/api/collaboration.routes.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep your only 1 route for get all collaborators and remove all your rest changes

backend/Controllers/collaboration.controller.js
return res.status(200).json({collaborators: existingCollaborators});
} catch (error) {


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about after catch?

backend/Controllers/collaboration.controller.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary line additions?

@Avdhesh-Varshney Avdhesh-Varshney force-pushed the main branch 2 times, most recently from 7446ed0 to f368eb7 Compare September 28, 2025 04:52
@Avdhesh-Varshney
Copy link
Member

@vansh909 Plz raise a new PR and also update your forked repo.
Closing because of a lots of merge conflicts and changes mentioned earlier.

For new PR, Plz follow the coding standard of other files. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney requested changes

Assignees

@vansh909 vansh909

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API Endpoint: Get List of Collaborators for a Project

2 participants

@vansh909 @Avdhesh-Varshney