Skip to content

added footer section #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+54 −4
Open

added footer section #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 53 additions & 1 deletion frontend/src/App.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ToastContainer } from 'react-toastify';
import 'react-toastify/dist/ReactToastify.css';
import { Routes, Route } from 'react-router-dom';
import { Routes, Route, Link } from 'react-router-dom';
import { FaGithub, FaTwitter, FaLinkedin } from 'react-icons/fa';
import LoginPage from './pages/LoginPage';
import RegisterPage from './pages/RegisterPage';
import SetupPage from './pages/SetupPage';
Expand All @@ -25,6 +26,7 @@ function App() {
<Route path="/login" element={<LoginPage />} />
<Route path="/register" element={<RegisterPage />} />
<Route path="/contact" element={<ContactUs />} />

{/* Protected Routes */}
<Route
path="/setup"
Expand All @@ -34,6 +36,7 @@ function App() {
</ProtectedRoute>
}
/>

{/* Protected Routes Wrapper */}
<Route
element={
Expand All @@ -53,6 +56,55 @@ function App() {
/>
</Route>
</Routes>

{/* Beautiful Footer Section */}
{/* Beautiful Footer Section */}
<footer className="bg-gray-900 text-gray-300 mt-0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of writing the footer component in App.jsx file.
Please write it into a separate component and setup accordingly for all necessary routes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why are there 2 same comments?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the author only told to that in jsx file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so tell me finally what should i do separate component or only app.jsx
\

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set up a separate component for specific routes.
@archa8 Could you please list all the routes that require a footer?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will just make a separate comopnent and import it to app.jsx main thats enough i guess it will reamain globally

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arihant2312, that is what I am telling you to rectify; the footer should NOT be present globally. At least the signup and login pages should not have the footer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will make the change

<div className="max-w-7xl mx-auto px-5 py-10 grid md:grid-cols-3 gap-24">

<div>
<h2 className="text-xl font-semibold text-white mb-3">Paisable</h2>
<p className="text-base text-gray-400">
Smart finance management made simple-track, budget, and plan your
expenses effortlessly.
</p>
</div>


<div>
<h3 className="text-lg font-semibold text-white mb-3 ">Quick Links</h3>
<ul className="space-y-2 text-sm">
<li><Link to="/dashboard" className="hover:text-indigo-400">Dashboard</Link></li>
<li><Link to="/transactions" className="hover:text-indigo-400">Transactions</Link></li>
<li><Link to="/budgets" className="hover:text-indigo-400">Budgets</Link></li>
<li><Link to="/contact" className="hover:text-indigo-400">Contact Us</Link></li>
</ul>
</div>


<div>
<h3 className="text-lg font-semibold text-white mb-3">Connect</h3>
<div className="flex space-x-4">
<a href="https://github.com" target="_blank" rel="noreferrer" className="hover:text-indigo-400">
<FaGithub size={22} />
</a>
<a href="https://twitter.com" target="_blank" rel="noreferrer" className="hover:text-indigo-400">
<FaTwitter size={22} />
</a>
<a href="https://linkedin.com" target="_blank" rel="noreferrer" className="hover:text-indigo-400">
<FaLinkedin size={22} />
</a>
</div>
</div>
</div>


<div className="text-center py-4 text-lg text-gray-500 bg-gray-900">
© {new Date().getFullYear()} Paisable. All rights reserved.
</div>
</footer>


<ToastContainer />
</>
);
Expand Down
4 changes: 1 addition & 3 deletions frontend/src/pages/WelcomePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ export default function WelcomePage() {
</section>

{/* Footer */}
<footer className="py-8 text-center text-gray-500 dark:text-gray-400">
<p>&copy; {new Date().getFullYear()} Paisable. All Rights Reserved.</p>
</footer>

</div>
);
}