Added internal store for tasks #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masecla22
reviewed
Sep 17, 2025
There was a problem hiding this comment.
Get this garbage out of my repository.
There was a problem hiding this comment.
This needs to be gitignored
| @@ -1,9 +1,14 @@ | |||
| package masecla.remindify.dto; | |||
|
|
|||
| import jakarta.persistence.*; | |||
There was a problem hiding this comment.
I'd rather not have a star import for two annotations.
Comment on lines
+4
to
+11
| spring.datasource.url=jdbc:h2:file:./data/remindify-new | ||
| spring.datasource.driver-class-name=org.h2.Driver | ||
| spring.datasource.username=username | ||
| spring.datasource.password=password | ||
|
|
||
| spring.jpa.hibernate.ddl-auto=update | ||
|
|
||
| spring.h2.console.enabled=true |
There was a problem hiding this comment.
Please document how these are meant to be used / switch from local to remote mysql
masecla22
reviewed
Sep 17, 2025
Comment on lines
27
to
28
| TaskDto persisted = task.getId() == null ? taskRepository.save(task) : task; | ||
| log.info("Task with id {} has been created.", persisted.getId()); |
There was a problem hiding this comment.
Make a TaskService and call it from here, I don't want the consumer service to touch the dto repo
|
Fixes #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bonjour ampù l'amicu