M26 prevent unenroll #259
Open
M26 prevent unenroll #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefdworschak
requested changes
Dec 8, 2021
There was a problem hiding this comment.
Actually as per #229, this should be for participants which is in enrollpart.html not in enrollstaff.html which is the logic for Judges/Facilitators.
Also, unenrollment should not be allowed as soon as teams are assigned or the status is hack_in_progress, judging, finished or deleted.
|
I'll fix this @stefdworschak just still not feeling well, recovering from COVID :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to avoid participants withdrawing if hackathon status is in-progress or anything further, the withdraw button is disabled based on hackathon.status
Pull request type
Related Issue
Configuration instructions
Testing
Manual testing: checked all hackathon statuses and "Withdraw as Participant" button is behaving as expected.
Screenshots
Additional Information
Does this introduce a breaking change