Language server installation menu #1997

FastestMolasses · 2025-02-25T06:40:37Z

Description

A system to allow users to download and manage LSP servers from the settings menu. This utilizes the mason registry to track the language servers.

Related Issues

Checklist

I read and understood the contributing guide as well as the code of conduct
The issues this PR addresses are related to each other
My changes generate no new warnings
My code builds and runs on my machine
My changes are all related to the related issue above
I documented my code

Screenshots

CodeEdit/Features/LSP/Registry/PackageManagers/CargoPackageManager.swift

CodeEdit/Features/LSP/Registry/RegistryManager.swift

FastestMolasses · 2025-03-12T12:17:58Z

Will need to fix lint errors, but besides that it is ready for review.

austincondiff · 2025-03-12T21:55:46Z

Fix those SwiftLint errors plz 😬

tom-ludwig

I’ve reviewed the Installation Queue and Package Managers so far. This PR is definitely too large for a single review, so I’ll go through the rest later. In the meantime, could you update your PR description as well?

CodeEdit/Features/LSP/Registry/PackageManagers/CargoPackageManager.swift

CodeEdit/Features/LSP/Registry/PackageManagers/GithubPackageManager.swift

CodeEdit/Features/LSP/Registry/PackageManagers/GolangPackageManager.swift

CodeEdit/Features/LSP/Registry/PackageManagers/NPMPackageManager.swift

CodeEdit/Features/LSP/Registry/PackageManagers/PipPackageManager.swift

CodeEdit/Features/LSP/Registry/InstallationQueueManager.swift

thecoolwinter · 2025-04-09T16:41:48Z

CodeEdit/Features/LSP/Registry/PackageManagerProtocol.swift

+
+extension PackageManagerProtocol {
+    /// Creates the directory for the language server to be installed in
+    internal func createDirectoryStructure(for packagePath: URL) throws {


Suggested change

internal func createDirectoryStructure(for packagePath: URL) throws {

func createDirectoryStructure(for packagePath: URL) throws {

Internal is redundant

thecoolwinter · 2025-04-09T16:41:56Z

CodeEdit/Features/LSP/Registry/PackageManagerProtocol.swift

+    }
+
+    /// Executes commands in the specified directory
+    internal func executeInDirectory(in packagePath: String, _ args: [String]) async throws -> [String] {


Suggested change

internal func executeInDirectory(in packagePath: String, _ args: [String]) async throws -> [String] {

func executeInDirectory(in packagePath: String, _ args: [String]) async throws -> [String] {

thecoolwinter · 2025-04-09T16:42:02Z

CodeEdit/Features/LSP/Registry/PackageManagerProtocol.swift

+    }
+
+    /// Runs a shell command and returns output
+    internal func runCommand(_ command: String) async throws -> [String] {


Suggested change

internal func runCommand(_ command: String) async throws -> [String] {

func runCommand(_ command: String) async throws -> [String] {

thecoolwinter · 2025-04-09T16:42:38Z

CodeEdit/Features/LSP/Registry/PackageManagerProtocol.swift

+    }
+}
+
+enum PackageManagerError: Error {


All these enums should have their own file

thecoolwinter · 2025-04-09T16:44:43Z

CodeEdit/Features/LSP/Registry/PackageManagers/GithubPackageManager.swift

+    }
+
+    private func downloadBinary(_ source: PackageSource, _ url: URL) async throws {
+        _ = try await URLSession.shared.data(from: url)


Is this not just throwing away the downloaded data? I think this should be saved to a file here

thecoolwinter · 2025-04-09T16:57:42Z

CodeEdit/Features/LSP/Registry/RegistryManager.swift

+        fail failed: Bool
+    ) {
+        if failed {
+            NotificationCenter.default.post(


I feel like this should be a notification instead of an activity view item. cc @austincondiff, you might have a stronger opinion on those semantics.

thecoolwinter · 2025-04-09T16:59:43Z

CodeEdit/Features/LSP/Registry/RegistryManager+HandleRegistryFile.swift

+            case .invalidResponse(let statusCode):
+                print("Invalid response received: \(statusCode)")
+            case let .downloadFailed(url, error):
+                print("Download failed for \(url.absoluteString): \(error.localizedDescription)")
+            case let .maxRetriesExceeded(url, error):
+                print("Max retries exceeded for \(url.absoluteString): \(error.localizedDescription)")
+            case let .writeFailed(error):
+                print("Failed to write files to disk: \(error.localizedDescription)")


I'd prefer error messages be in the localizedError variable on the error, rather than in a method somewhere detached from the error type. That would simplify this method as well.

Also, lets use a Logger here and elsewhere for logging errors and status. That'll make these logs easier to track down and we can attach severity to them.

thecoolwinter · 2025-04-09T17:00:44Z

CodeEdit/Features/LSP/Registry/RegistryManager+HandleRegistryFile.swift

All the uses of internal here are redundant. Methods and variables are internal by default.

thecoolwinter · 2025-04-09T17:04:17Z

CodeEdit/Features/LSP/Service/LSPService.swift

@@ -11,6 +11,7 @@ import Foundation
 import LanguageClient
 import LanguageServerProtocol
 import CodeEditLanguages
+import SwiftUICore


Suggested change

import SwiftUICore

import SwiftUI

thecoolwinter · 2025-04-09T17:24:06Z

CodeEdit/Features/LSP/Service/LSPService.swift

I really dislike the addition of SwiftUI in this file, but after trying to solve it we may need to work out a better method for opening windows more generally. We'll keep this for now, and thanks for adding that TODO.

Language server installation menu

5ea9de5

FastestMolasses added enhancement New feature or request language server Issues or Pull Requests related to language servers. labels Feb 25, 2025

matthijseikelenboom reviewed Feb 25, 2025

View reviewed changes

CodeEdit/Features/LSP/Registry/PackageManagers/CargoPackageManager.swift Show resolved Hide resolved

CodeEdit/Features/LSP/Registry/RegistryManager.swift Show resolved Hide resolved

austincondiff assigned FastestMolasses Mar 4, 2025

FastestMolasses added 8 commits March 4, 2025 14:50

Lint

d8ca6b2

Merge branch 'main' into lsp-install

95479a5

Added notification on file open

ca48313

Small update

80d16d9

Merge branch 'main' into lsp-install

4c22bc3

Refactors

21f7138

Connect install button

c827108

Refactors

b9d3945

FastestMolasses marked this pull request as ready for review March 12, 2025 12:17

FastestMolasses requested review from austincondiff, matthijseikelenboom, thecoolwinter and tom-ludwig March 12, 2025 12:18

FastestMolasses added 10 commits March 13, 2025 01:34

Fix lint

6c9c48a

Refactors, added settings loading

ee93abb

Refactors, added text icon colors

2f2c022

Update notifications

ed9dfe6

Add more documentation

64ceb74

Added installation queuing, fix runtime warnings

04fde2c

Convert to actor

6b40bb3

Refactors, fix and update removals

0fe73ef

Fix queue feedback and clean up memory

b5d7186

Small refactors

1db6a66

Temporarily removed Language Servers menu

1ec3820

tom-ludwig requested changes Mar 21, 2025

View reviewed changes

FastestMolasses added 2 commits March 31, 2025 03:14

Small refactors

6747bf5

Merge branch 'main' into lsp-install

08963a2

FastestMolasses requested a review from tom-ludwig March 31, 2025 10:16

austincondiff previously approved these changes Apr 2, 2025

View reviewed changes

austincondiff reviewed Apr 2, 2025

View reviewed changes

CodeEdit/Features/LSP/Registry/InstallationQueueManager.swift Show resolved Hide resolved

thecoolwinter added 2 commits April 9, 2025 11:37

Merge branch 'main' into lsp-install

ae57197

Correct CESE Version In XcodeProj File

74bf7e5

thecoolwinter dismissed austincondiff’s stale review via 74bf7e5 April 9, 2025 16:38

thecoolwinter requested changes Apr 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Language server installation menu #1997

Language server installation menu #1997

FastestMolasses commented Feb 25, 2025

FastestMolasses commented Mar 12, 2025

austincondiff commented Mar 12, 2025

tom-ludwig left a comment

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

thecoolwinter Apr 9, 2025

	internal func createDirectoryStructure(for packagePath: URL) throws {
	func createDirectoryStructure(for packagePath: URL) throws {

	internal func executeInDirectory(in packagePath: String, _ args: [String]) async throws -> [String] {
	func executeInDirectory(in packagePath: String, _ args: [String]) async throws -> [String] {

	internal func runCommand(_ command: String) async throws -> [String] {
	func runCommand(_ command: String) async throws -> [String] {

Language server installation menu #1997

Are you sure you want to change the base?

Language server installation menu #1997

Conversation

FastestMolasses commented Feb 25, 2025

Description

Related Issues

Checklist

Screenshots

FastestMolasses commented Mar 12, 2025

austincondiff commented Mar 12, 2025

tom-ludwig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment