Skip to content

Replace Simpsons seed data with faker #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
stoopidJSON opened this issue Aug 19, 2020 · 4 comments
Open
2 tasks

Replace Simpsons seed data with faker #246

stoopidJSON opened this issue Aug 19, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stoopidJSON
Copy link
Member

Task

Instead of the JSON let's grab a ton of fake data and really fill out a test build!

Acceptance Criteria

  • faker is used to seed data
  • Simpsons JSON is removed.

Notes

https://www.npmjs.com/package/faker

@stoopidJSON stoopidJSON added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 19, 2020
@blakenan-bellese
Copy link
Contributor

@revjtanton would this still be invoked by the npm run db-seed command?

@blakenan-bellese
Copy link
Contributor

@revjtanton I'm inclined to suggest that this faker include at least one facility of each of the types that are useful in HCRC (Assisted Living Facility, Mixed Housing, Senior Housing), but recognize that this would create a logical dependency between the two projects. Any suggestion on how to avoid? Can we somehow have an HCRC-faker, maybe as part of the HCRC project?

@mschechter-bellese
Copy link
Collaborator

@blakenan-bellese - I think that an HCRC faker would be good for populating an instance of Bmore-Responsive to use for HCRC development (maybe a separate project?); Bmore-Responsive has no functionality keyed off entity types, and we can test all the functionality around entities without having that data be specific to a use case such as HCRC.

Could you please clarify whether you want to use the faker to generate the JSON used for seeding, or use it dynamically during the seeding process? The latter is much more complex, and would also add test complexity because we would not have any known data we could reference explicitly.

@blakenan-bellese
Copy link
Contributor

blakenan-bellese commented Apr 15, 2021 via email

@mschechter-bellese mschechter-bellese self-assigned this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants