start to cleanup with eslint

Author: pwolanin

.eslintrc.js

@@ -28,7 +28,8 @@ module.exports = {
     'no-debugger': 'warn',
     'prefer-const': 'error',
     'no-var': 'error',
-    
+    "prefer-destructuring": "off",
+
     // Cypress specific rules
     'cypress/no-unnecessary-waiting': 'warn',
     'cypress/assertion-before-screenshot': 'warn',

cypress.config.js

@@ -22,14 +22,12 @@ module.exports = defineConfig({
       openMode: 0,
     },
     setupNodeEvents(on, config) {
-      on("dev-server:start", (options) => {
-        return startDevServer({
+      on("dev-server:start", (options) => startDevServer({
           options,
           viteConfig: {
             configFile: "vite.config.js", // Path to your Vite config file
           },
-        });
-      });
+        }));
 
       return config;
     },

cypress/e2e/e2e_tests.cy.js

@@ -5,8 +5,8 @@ describe('E2E Tests', () => {
   let demURL;
   let repURL;
   // Set indices for Leaders used in tests
-  let demIndex = 22;
-  let repIndex = 46;
+  const demIndex = 22;
+  const repIndex = 46;
 
   describe('Ward Leaders List', () => {
     beforeEach(() => {
@@ -120,9 +120,9 @@ describe('E2E Tests', () => {
     });
 
     it('should display placeholders when information is missing', () => {
-      let missingData = Object.keys(demLeader).filter(key => demLeader[key] === null || demLeader[key] === undefined);
+      const missingData = Object.keys(demLeader).filter(key => demLeader[key] === null || demLeader[key] === undefined);
       // Look for missing data in fields besides subward and photo
-      let filteredMissingData = missingData.filter(item => !['subWard','photo'].includes(item))
+      const filteredMissingData = missingData.filter(item => !['subWard','photo'].includes(item))
       if (filteredMissingData.length > 0) {
         cy.get('.unknown').should('have.length.at.least', 1);
       }

cypress/support/e2e.js

@@ -1,9 +1,8 @@
 import { mount } from 'cypress/vue';
 import  Api  from '../../src/api';
 import { CONTENTFUL_SPACE_ID, CONTENTFUL_ACCESS_TOKEN } from '../../src/config'
+
 const api = new Api(CONTENTFUL_SPACE_ID, CONTENTFUL_ACCESS_TOKEN)
 
 Cypress.Commands.add('mount', mount);
-Cypress.Commands.add('fetchLeaders', () => {
-    return cy.wrap(api.fetchLeaders());
-});
+Cypress.Commands.add('fetchLeaders', () => cy.wrap(api.fetchLeaders()));

src/api/index.js

@@ -44,9 +44,9 @@ export default class Api {
     return this.client.getEntries(requestOpts).then((response) => {
       if (response.items.length > 0) {
         return simplifyLinkedItems(getFieldsAndId(response.items[0]));
-      } else {
+      } 
         throw new Error("Ward leader was not found");
-      }
+      
     });
   }
 
@@ -85,9 +85,9 @@ export default class Api {
       .then((response) => {
         if (response.items.length > 0) {
           return getFieldsAndId(response.items[0]);
-        } else {
+        } 
           throw new Error("Page not found");
-        }
+        
       });
   }
 

src/components/geocoder.vue

@@ -63,7 +63,7 @@ export default {
       "expanded",
       "position",
     ]);
-    const opts = Object.assign({}, this.options, overrides);
+    const opts = { ...this.options, ...overrides};
 
     this.geocoder = L.control.geocoder(this.apikey, opts);
     eventsBinder(this, this.geocoder, events);
@@ -75,7 +75,7 @@ export default {
     deferredMountedTo(parent) {
       this.parent = parent;
       this.geocoder.addTo(parent);
-      for (var i = 0; i < this.$children.lenth; i++) {
+      for (let i = 0; i < this.$children.lenth; i++) {
         this.$children[i].deferredMountedTo(parent);
       }
     },
@@ -93,8 +93,8 @@ export default {
 // Copied from vue2-leaflet/src/utils/eventsBinder.js
 // Can't import it because babel won't transpile files from node_modules
 function eventsBinder(vueElement, leaflet, events) {
-  for (var i = 0; i < events.length; i++) {
-    const exposedName = "l-" + events[i];
+  for (let i = 0; i < events.length; i++) {
+    const exposedName = `l-${  events[i]}`;
     const eventName = events[i];
     leaflet.on(eventName, (ev) => {
       vueElement.$emit(exposedName, ev);

src/components/links-list.vue

@@ -17,9 +17,7 @@ export default {
     links: {
       type: Array,
       required: true,
-      validator: (links) => {
-        return links.every((link) => "title" in link && "url" in link);
-      },
+      validator: (links) => links.every((link) => "title" in link && "url" in link),
     },
   },
 };

src/router/index.js

@@ -56,9 +56,9 @@ const router = createRouter({
 function scrollBehavior(to, from, savedPosition) {
   if (savedPosition) {
     return savedPosition;
-  } else {
+  } 
     return { x: 0, y: 0 };
-  }
+  
 }
 
 export default router;

src/store/getters.js

@@ -2,7 +2,7 @@ export function partyPlural(state) {
   const party = state.currentLeader.leader.party;
   if (party === "democratic") {
     return "democrats";
-  } else if (party === "republican") {
+  } if (party === "republican") {
     return "republicans";
   }
 }
@@ -16,7 +16,7 @@ export function partyTitle(state) {
   const party = state.currentLeader.leader.party;
   if (party === "democratic") {
     return "Democratic";
-  } else if (party === "republican") {
+  } if (party === "republican") {
     return "Republican";
   }
 }

src/views/feedback.vue

@@ -103,6 +103,7 @@
 
 <script>
 import axios from "axios";
+
 export default {
   name: "Feedback",
   data() {
@@ -181,7 +182,7 @@ export default {
       Object.entries(this.formParams).forEach(([key, value]) => {
         bodyFormData.append(key, value);
       });
-      axios.post(this.formUrl, bodyFormData).catch(function (error) {
+      axios.post(this.formUrl, bodyFormData).catch((error) => {
         console.log(error);
       });
       this.submitted = true;