Vue3 upgrade #296
Merged
Vue3 upgrade #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still in progress? |
|
Yes, we worked on it yesterday on a call. See recent commits.
Hopefully will merge soon
…On Wed, Jan 15, 2025, 11:19 millmason ***@***.***> wrote:
Is this still in progress?
—
Reply to this email directly, view it on GitHub
<#296 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2JKYWAA3V52V3I6BDMRD2K2C7RAVCNFSM6AAAAABHXCPWVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTGM3DIMJUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
… match Cypress Config
pwolanin
commented
Mar 4, 2025
src/App.vue
Outdated
| 'nav-bar': NavBar, | ||
| 'notification': Notification, | ||
| 'b-loading': Buefy.Loading, | ||
| // 'b-loading': Buefy.Loading, |
There was a problem hiding this comment.
remove commented code
public/index.html
Outdated
| <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"> | ||
| <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"> | ||
| <script type="module" crossorigin src="/assets/index-kiSjSFJe.js"></script> | ||
| <link rel="stylesheet" crossorigin href="/assets/index-ftazVGU5.css"> |
There was a problem hiding this comment.
let's take these out, maybe add a html comment
pwolanin
commented
Mar 4, 2025
There was a problem hiding this comment.
can remove this file too?
vvi230714
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.