Skip to content

Support for the express@5.x #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pnkp opened this issue Oct 21, 2024 · 1 comment
Open

Support for the express@5.x #691

pnkp opened this issue Oct 21, 2024 · 1 comment

Comments

@pnkp
Copy link
Contributor

pnkp commented Oct 21, 2024

A new version of Express.js was recently released.
Unfortunately, the serverless-express does not support the new version.

The main issue occurs during request parsing with the body-parser. After updating to version 5.x, the request body is not parsed, and we receive a Buffer instance as the body

pnkp pushed a commit to pnkp/serverless-express that referenced this issue Oct 21, 2024
* upgraded to the express@5.x,
* adjusted the ServerlessRequest to the express@5.x implementation,
* ran: npm audit and npm audit fix,
pnkp pushed a commit to pnkp/serverless-express that referenced this issue Oct 24, 2024
* removed unnecessary workflows for the node.js 14 and 16,
* updated the Node.js engine version to >= 18
brettstack pushed a commit that referenced this issue Oct 24, 2024
* feat: upgrade to the express@5.x (#691)

* upgraded to the express@5.x,
* adjusted the ServerlessRequest to the express@5.x implementation,
* ran: npm audit and npm audit fix,

* feat: upgrade to the express@5.x (#691)

* removed unnecessary workflows for the node.js 14 and 16,
* updated the Node.js engine version to >= 18

---------

Co-authored-by: pantyporowicz <pantyporowicz@squiz.net>
github-actions bot pushed a commit that referenced this issue Oct 24, 2024
# [4.16.0](v4.15.0...v4.16.0) (2024-10-24)

### Features

* add support for Express v5 ([#691](#691)) ([#692](#692)) ([d20e3f0](d20e3f0))
@felhag
Copy link

felhag commented Feb 4, 2025

I suppose this ticket can be closed since it is added in the 4.16.0 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants